You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[ ] Regression
[ ] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.
Current behavior
Currently the gRPC server implementation, the call.request is being passed in, however, for client-side streaming (and bi-directional streaming), there isn't request field in the call, but rather call itself is a readable stream on its own.
NestJS handlers should be able to detect whether or not the grpc call has client-side streaming, and pass call directly.
Minimal reproduction of the problem with instructions
N/A
What is the motivation / use case for changing the behavior?
We are already doing great work encapsulating gRPC microservices, it would be cool to have full client-side streaming support. I am not sure if we should go full-on observable style for processing the client-side streaming calls, but I am all for it since I am in love with Rx and NestJS is already converting server-side streaming handshake to use observables.
Environment
Nest version: 5.x, 6.x
For Tooling issues:
- Node version: XX
- Platform:
Others:
The text was updated successfully, but these errors were encountered:
I'm submitting a...
Current behavior
Currently the gRPC server implementation, the
call.request
is being passed in, however, for client-side streaming (and bi-directional streaming), there isn'trequest
field in thecall
, but rathercall
itself is a readable stream on its own.Reference:
in
grpc-node
package:https://github.com/grpc/grpc-node/blob/master/packages/grpc-native-core/index.d.ts#L385
https://github.com/grpc/grpc-node/blob/master/packages/grpc-native-core/index.d.ts#L462
in
nestjs-microservices
package:https://github.com/nestjs/nest/blob/master/packages/microservices/server/server-grpc.ts#L134
https://github.com/nestjs/nest/blob/master/packages/microservices/server/server-grpc.ts#L144
Expected behavior
NestJS handlers should be able to detect whether or not the grpc call has client-side streaming, and pass
call
directly.Minimal reproduction of the problem with instructions
N/A
What is the motivation / use case for changing the behavior?
We are already doing great work encapsulating gRPC microservices, it would be cool to have full client-side streaming support. I am not sure if we should go full-on observable style for processing the client-side streaming calls, but I am all for it since I am in love with Rx and NestJS is already converting server-side streaming handshake to use observables.
Environment
The text was updated successfully, but these errors were encountered: