Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): remove dependencies grpc #1425

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Sep 21, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe:

What is the current behavior?

Issue Number: #1422

What is the new behavior?

the file grpc.health.ts should depends on @grpc/grpc-js package and not from the grpc package

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR, the file grpc.health.ts should depends on @grpc/grpc-js package and not from the grpc package

@Tony133
Copy link
Contributor Author

Tony133 commented Sep 21, 2021

if the change is correct say remove it from the package.json.

ahaha it has already been removed, sorry 😄

@BrunnerLivio BrunnerLivio merged commit 432300f into nestjs:master Sep 22, 2021
@BrunnerLivio
Copy link
Member

Thanks @Tony133 !

@Tony133 Tony133 deleted the chore/update-microservice-grpc branch October 5, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants