[BUG] string Slug incorrectly parsed as Date if in a specific format

[Bnaya]

I have a controller that looks like so:

@Crud({
  model: {
    type: Product,
  },
  params: {
    id: {
      field: "id",
      type: "string",
      primary: true,
    },
  },

When GET ing product with id like so: /api/products/product-123123
The SQL query ends with:

WHERE `Brand`.`bt_brand_id` = ?) `distinctAlias` ORDER BY `Brand_bt_brand_id` ASC LIMIT 100 -- PARAMETERS: ["0122-12-31T21:39:06.000Z"]

When the ID format is not STRING-NUMBER, its all file.

I assume the lib has some heuristics, that are incorrect?
Maybe it's here:

crud/packages/crud-request/src/request-query.parser.ts

Line 167 in 3d3f604

private parseValue(val: any) {

[Bnaya]

After additional debug, the issue is here:

crud/packages/crud-request/src/request-query.parser.ts

Lines 255 to 260 in 3d3f604

	validateParamOption(this._paramsOptions, name);
	const option = this._paramsOptions[name];
	const value = this.parseValue(this._params[name]);
	switch (option.type) {
	case 'number':

Even tho the type is configured as string, this.parseValue parses it as Date.
parseValue should get optional expected type, and only if it's not there, should fallback to heuristic parsing.

[Bnaya]

My Workaround:

// workaround for https://github.com/nestjsx/crud/issues/161
const m = require("@nestjsx/util/lib/checks.util.js");
const origIsDateString = m.isDateString;
m.isDateString = (v: any) => {
  if (typeof v === "string") {
    if (/^[a-z]+-[0-9]+$/i.test(v)) {
      return false;
    }
  }

  return origIsDateString.apply(m, [v]);
};

[sgrebnov]

Same issue - I use the following filter "?filter=someParam||cont||CG-7" and "CG-7" is automatically resolved to date time

[Bnaya]

More up to date workaround:

// workaround for https://github.com/nestjsx/crud/issues/161
const m = require("@nestjsx/util/lib/checks.util.js");
const origIsDateString = m.isDateString;

// eslint-disable-next-line no-useless-escape
const datePattern = /^(\d{4})-(\d{2})-(\d{2})T(\d{2}):(\d{2}):(\d{2}(?:\.\d*)?)(Z|([+\-])(\d{2}):(\d{2}))$/;

m.isDateString = (v: any) => {
  if (typeof v === "string") {
    if (!datePattern.test(v)) {
      return false;
    }
  }

  return origIsDateString.apply(m, [v]);
};

[sgrebnov]

Looks like parameter should be escaped so it works correctly (string is passed as-is w/o attempt to be converted to date time); The following works for me:
?filter=someParam||cont||CG-7 -> ?filter=someParam||cont||"CG-7"

[Bnaya]

I think its due to json.parse that is part of the pipeline
This behavior is not documented and i dont see why regular string wont work