selected fields on joins don't work

[jbrousseau]

First thank you for this awesome library!

According to documentation:

join
Receive joined relational objects in GET result (with all or selected fields)
?join=relation||field1,field2

But when I use field1, field2 in the HTTP query, it doesn't select these fields (I tried with latest v4.6.1). Instead, it select all the allowed fields defined in CrudOptions.

It's seems that it is due to the fact that in:
packages/crud-typeorm/src/typeorm-crud.service.ts

In function setJoin

      const select = [
        ...allowedRelation.primaryColumns,
        ...(options.persist && options.persist.length ? options.persist : []),
        ...allowedRelation.allowedColumns,
      ].map((col) => `${alias}.${col}`);

There is some filter missing somewhere, like this one (Note: I haven't tested yet the modification code below):

      const select = [
        ...allowedRelation.primaryColumns,
        ...(options.persist && options.persist.length ? options.persist : []),
        ...allowedRelation.allowedColumns,
      ]
     .filter((col) => !cond.select?.length || cond.select.includes(col)
     .map((col) => `${alias}.${col}`);

Thanks you for your feedback!

[michaelyali]

Thanks, I'll check it right now

[michaelyali]

fixed with v4.6.2

[jbrousseau]

wow, awesome, thank you!