Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Light/Dark Mode and Login Info from Printed Pages #18183

Closed
jchambers2012 opened this issue Dec 9, 2024 · 2 comments · Fixed by #18185
Closed

Hide Light/Dark Mode and Login Info from Printed Pages #18183

jchambers2012 opened this issue Dec 9, 2024 · 2 comments · Fixed by #18185
Assignees
@jchambers2012
Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@jchambers2012
Copy link
Contributor

jchambers2012 commented Dec 9, 2024 •
edited
Loading

Deployment Type

Self-hosted

Triage priority

I volunteer to perform this work (if approved)

NetBox Version

v4.1.7

Python Version

3.10

Steps to Reproduce

  1. Goto any object page at https://demo.netbox.dev/
  2. Ctrl-P
  3. View that the Lightmode/User menu exists.
    image

Expected Behavior

The site should suppress these items as they are also in the same section as the search input “d-print-none”

netbox/netbox/templates/base/layout.html

Line 60 in 674af4d

<header class="navbar navbar-expand-md sticky-top d-none d-lg-flex d-print-none">

Observed Behavior

It looks like the desktop version print view is somehow using/trigger the mobile view. I tested on both Chrome (131.0.6778.109 (Official Build) (64-bit)) and Firefox (128.5.1esr (64-bit)). Adding “d-print-none” to mobile view fixes the issue.
image
@jchambers2012 jchambers2012 added status: needs triage This issue is awaiting triage by a maintainer type: bug A confirmed report of unexpected behavior in the application labels Dec 9, 2024
@jchambers2012
Copy link
Contributor Author

I can submit a PR is wanted for this fix: jchambers2012@4586332

@jeremystretch
Copy link
Member

Thanks @jchambers2012 I'll assign this to you for a PR.

@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation severity: low Does not significantly disrupt application functionality, or a workaround is available and removed status: needs triage This issue is awaiting triage by a maintainer labels Dec 9, 2024
@jchambers2012 jchambers2012 mentioned this issue Dec 9, 2024
Merged
@jeremystretch jeremystretch mentioned this issue Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchambers2012 jchambers2012

Labels
severity: low Does not significantly disrupt application functionality, or a workaround is available status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes 18183 - Hide Light/Dark Mode and Login Info from Printed Pages jchambers2012/netbox
2 participants
@jchambers2012 @jeremystretch