Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No test failures with @netlify/[email protected] #4679

Closed
danez opened this issue Nov 7, 2022 · 2 comments · Fixed by #4744
Closed

No test failures with @netlify/[email protected] #4679

danez opened this issue Nov 7, 2022 · 2 comments · Fixed by #4744

Comments

@danez
Copy link
Contributor

danez commented Nov 7, 2022 •
edited
Loading

Some tests should fail with version 9.4.0 of @netlify/framework-info, because @netlify/[email protected] is missing files.

We need to add tests that use @netlify/framework-info and fail if it does not work.

Ref: netlify/framework-info#827
@danez danez mentioned this issue Dec 6, 2022
Merged
5 tasks
@lukasholzer
Copy link
Contributor

basically we have test that use the framework info 🤔 I think we should move the framework info into the build monorepo to make feedback loops easier and testing things out better without the need of releasing first.

@lukasholzer
Copy link
Contributor

Furthermore I will make the buildbot stage of framework detection failing (so that we should get immediate feedback if we broke something)

@danez danez mentioned this issue Dec 6, 2022
Merged
5 tasks
@kodiakhq kodiakhq bot closed this as completed in #4744 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add test to ensure framework detection works correctly netlify/build
2 participants
@danez @lukasholzer