Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove oclif and replace with commander #3716

Closed
lukasholzer opened this issue Nov 26, 2021 · 3 comments · Fixed by #3717
Closed

Remove oclif and replace with commander #3716

lukasholzer opened this issue Nov 26, 2021 · 3 comments · Fixed by #3717
Assignees
Labels
type: chore work needed to keep the product and development running smoothly

Comments

@lukasholzer
Copy link
Contributor

The full problem and discussion about which tool can be found on our internal issue: https://github.com/netlify/pod-workflow/issues/343

@lukasholzer lukasholzer added the type: chore work needed to keep the product and development running smoothly label Nov 26, 2021
@lukasholzer lukasholzer self-assigned this Nov 27, 2021
@XhmikosR
Copy link
Contributor

XhmikosR commented Jan 4, 2022

@lukasholzer @erezrokah would it make sense to use commander instead of minimist too? minimist is currently used in netlify-lambda only:

src/lib/functions/runtimes/js/builders/netlify-lambda.js:5:const minimist = require('minimist')
src/lib/functions/runtimes/js/builders/netlify-lambda.js:22:    const match = minimist(script.split(' '))

@erezrokah
Copy link
Contributor

@lukasholzer @erezrokah would it make sense to use commander instead of minimist too? minimist is currently used in netlify-lambda only:

Yes it will. We were trying to scope down this big refactoring as much as possible.
This especially makes sense since netlify-lambda uses commander too https://github.com/netlify/netlify-lambda/blob/1645b4aff5914eff4c4952dfa26ad57b78599188/bin/cmd.js#L7

@XhmikosR
Copy link
Contributor

XhmikosR commented Jan 4, 2022

Cool, I have already included this suggestion in #3941, feel free to add more there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants