Remove superfluous arguments #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would suggest adding CodeQL to the repo. CodeQL is the successor to LGTM (both owned by GitHub). |
XhmikosR
commented
Jan 3, 2022
| @@ -45,15 +45,14 @@ const config = { | |||
| return md | |||
| } | |||
| }, | |||
| GENERATE_COMMANDS_LIST(content, options, instance) { | |||
| const context = path.basename(instance.originalPath, '.md') | |||
| GENERATE_COMMANDS_LIST() { | |||
There was a problem hiding this comment.
Not sure if this is tested somehow, but all of them seem to be unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixing a few of the LGTM issues
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
PS. not super familiar with the commit messages you might be using, so feel free to tweak it while merging.