feat: add trailing slash to regular expressions #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
charliegroll
reviewed
May 4, 2022
| @@ -30,7 +30,7 @@ const generateManifest = ({ bundles = [], declarations = [], functions }: Genera | |||
| return | |||
| } | |||
|
|
|||
| const pattern = 'pattern' in declaration ? new RegExp(declaration.pattern) : globToRegExp(declaration.path) | |||
There was a problem hiding this comment.
wait what is this 'pattern' in declaration? is that the same as declaration?.pattern? I almost never see in used
There was a problem hiding this comment.
Yes, but since declaration is a union type (DeclarationWithPath or DeclarationWithPattern) and the pattern property only exists in one of them, the in allows us to disambiguate. So if you do:
if ('pattern' in declaration) {
// From this point on you know that `declaration` is of type
// `DeclarationWithPattern` and so does the TypeScript compiler.
}
charliegroll
approved these changes
May 4, 2022
|
Do we need to worry about the case where a customer wants different behavior for /path and /path/ ? I haven't seen requests for that, just wanted to mention it as a potential cost of this implementation. |
mraerino
approved these changes
May 5, 2022
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
This PR changes the regular expressions generated from a
pathdeclaration so that they contain an optional trailing slash.So
/foowill yield^/foo/?$instead of^/foo$.