feat: support for multiple paths in in source configuration #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
reviewed
Nov 30, 2022
node/declaration.ts
Outdated
| declarations.push({ ...declaration, ...config, path }) | ||
| }) | ||
| // if empty path array with cache set, add declaration with cache | ||
| else if (config.cache) declarations.push({ ...declaration, cache: config.cache }) |
There was a problem hiding this comment.
I'm not sure I understand why we're addressing the cache property specifically here. What happens if we add more configuration properties? Will they have to be added to these conditions?
There was a problem hiding this comment.
@eduardoboucas I made a change that will include any type of config, I think it had to do with the overall conditional in the function. Let me know if it doesn't make sense?
khendrikse
force-pushed
the
feat/support-multiple-paths-in-isc
branch
from
c1ae79c to
cbf007d
Compare
khendrikse
force-pushed
the
feat/support-multiple-paths-in-isc
branch
from
b84e1a7 to
e401ff3
Compare
test/fixtures/with_config/.netlify/edge-functions/framework-func1.ts
Outdated
Show resolved
Hide resolved
|
@eduardoboucas sorry all my comments weren't sent because I did not review correctly :p |
Co-authored-by: Eduardo Bouças <[email protected]>
eduardoboucas
approved these changes
Dec 6, 2022
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
Apr 23, 2024
…edge-bundler#230) * feat: support for multiple paths in in source configuration * fix: use array for isc path properties * fix: support both array and string path properties * fix: fix linting * fix: have a string usecase in declaration tests by transforming json array to string * fix: remove file-level eslint-disable-max-depth * fix: change conditional for cache config and path length * fix: change conditional for adding all different types of config * fix: remove fallback to empty object * fix: change comment * fix: undo changing config fixtures to use an array as path * fix: update comments * Update node/declaration.ts Co-authored-by: Eduardo Bouças <[email protected]> * fix: change mutation of config.path * fix: formatting Co-authored-by: khen <[email protected]> Co-authored-by: Eduardo Bouças <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for sending this pull request! 🎉
https://github.com/netlify/pod-compute/issues/295
This PR adds support for multiple paths in ISC. It allows for path to be either a string or array of strings.
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
