Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

fix(remix): use correct configuration file #663

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix(remix): use correct configuration file #663

merged 1 commit into from
Jan 12, 2022

Conversation

erezrokah
Copy link
Contributor

@erezrokah erezrokah commented Jan 12, 2022 •
edited
Loading

I believe #658 had a typo.

In my Remix project the config is a .js file and trying to switch to .mjs didn't work (that is changing the extension and using ES modules).

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 12, 2022
@erezrokah erezrokah requested a review from ascorbic January 12, 2022 13:22
@erezrokah erezrokah changed the title fix(remix): use correct configuration fix(remix): use correct configuration file Jan 12, 2022
ascorbic
ascorbic approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@erezrokah erezrokah merged commit e35f96e into main Jan 12, 2022
@erezrokah erezrokah deleted the fix/remix_support branch January 12, 2022 14:52
@token-generator-app token-generator-app bot mentioned this pull request Jan 12, 2022
Merged
@erezrokah erezrokah mentioned this pull request Jan 12, 2022
Merged
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erezrokah @ascorbic