Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

fix: fixed typo in qwik excluded dependency #805

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

nickytonline
Copy link
Contributor

@nickytonline nickytonline commented Aug 4, 2022

🎉 Thanks for submitting a pull request! 🎉

Summary

There was a typo in the excluded npm dependencies for the vite framework information, causing multiple frameworks to be returned fort Qwik. The typo has been fixed.

Now instead of

❯ ntl dev
Debugger attached.
◈ Netlify Dev ◈
◈ Ignored general context env var: LANG (defined in process)
? Multiple possible start commands found (Use arrow keys or type to search)
❯ [Qwik] 'npm run build.client' 
  [Qwik] 'npm run build.ssr' 
  [Qwik] 'npm run dev.client' 
  [Qwik] 'npm run dev.debug' 
  [Qwik] 'npm run dev.ssr' 
  [Vite] 'npm run build.client' 
  [Vite] 'npm run build.ssr' 
(Move up and down to reveal more choices)

when you run ntl dev, you'll get the following because only one framework is found.

◈ Starting Netlify Dev with Qwik

> build.client
> vite build

I think there's another issue when it runs ntl dev because it runs the first dev command it finds, e.g. build.client, but this is a completely separate issue that needs to be investigate.

Fixes #804


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This
    ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
    typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@nickytonline nickytonline self-assigned this Aug 4, 2022
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Aug 4, 2022
@nickytonline nickytonline merged commit 8a4352d into main Aug 4, 2022
@nickytonline nickytonline deleted the nickytonline/fix-vite-exclude-npm-dependencies branch August 4, 2022 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qwik excluded npm dependency for Vite framework info has a typo
2 participants