This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
fix: fixed typo in qwik excluded dependency #805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
There was a typo in the excluded npm dependencies for the vite framework information, causing multiple frameworks to be returned fort Qwik. The typo has been fixed.
Now instead of
when you run
ntl dev
, you'll get the following because only one framework is found.I think there's another issue when it runs
ntl dev
because it runs the first dev command it finds, e.g.build.client
, but this is a completely separate issue that needs to be investigate.Fixes #804
For us to review and ship your PR efficiently, please perform the following steps:
ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)