Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add SolidJS framework configuration #807

Closed
nickytonline opened this issue Aug 10, 2022 · 0 comments · Fixed by #813
Closed

Add SolidJS framework configuration #807

nickytonline opened this issue Aug 10, 2022 · 0 comments · Fixed by #813
Assignees
Labels
good first issue Good for newcomers type: feature code contributing to the implementation of a feature and/or user facing functionality

Comments

@nickytonline
Copy link
Contributor

nickytonline commented Aug 10, 2022

Which problem is this feature request solving?

We currently detect Solid Start, but not Solid JS

Describe the solution you'd like

Currently we only have a configuration for Solid Start. See https://github.com/netlify/framework-info/blob/main/src/frameworks/solid-start.json.

We'd need to add a solid-js.json configuration for SolidJS.

We’d need to do is look for the solid-js npm dependency and have solid-start in the excluded npm dependencies for a “vanilla” SolidJS app.

e.g.

{
  "id": "solid-js",
  "name": "SolidJS",
  "category": "static_site_generator",
  "detect": {
    "npmDependencies": ["solid-js"],
    "excludedNpmDependencies": ["solid-start"],
    "configFiles": []
  },
  "dev": {
    "command": "nom run dev",
    "port": 3000,
    "pollingStrategies": [{ "name": "TCP" }]
  },
  "build": {
    "command": "npm run build",
    "directory": "netlify"
  },
  "logo": {
    "default": "/logos/solid-js/default.svg",
    "light": "/logos/solid-js/default.svg",
    "dark": "/logos/solid-js/default.svg"
  },
  "env": {},
  "plugins": []
}

We'd also need SolidJS logos.

And we’d need to exclude the solid-js dependency from the vite framework info.

Describe alternatives you've considered

N/A

Can you submit a pull request?

Yes

@nickytonline nickytonline added good first issue Good for newcomers type: feature code contributing to the implementation of a feature and/or user facing functionality labels Aug 10, 2022
@ericapisani ericapisani self-assigned this Aug 23, 2022
@kodiakhq kodiakhq bot closed this as completed in #813 Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants