Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Change test_metis.py to test the exposed functions #26

Closed
ysitu opened this issue Jun 29, 2015 · 4 comments
Closed

Change test_metis.py to test the exposed functions #26

ysitu opened this issue Jun 29, 2015 · 4 comments

Comments

@ysitu
Copy link
Contributor

ysitu commented Jun 29, 2015

We should not be directly testing functions from _metis.pyx as those are implementation detail.

@ysitu ysitu added this to the networkx-metis-1.0 milestone Jun 29, 2015
@OrkoHunter
Copy link
Contributor

Okay.. So rather we'd be testing the functions present in the top level of networkx.addons.metis. Still didn't get what is going wrong with testing the _metis.pyx functions.

@ysitu
Copy link
Contributor Author

ysitu commented Jun 30, 2015

That is about the philosophy of testing. Impose constraints on only the public interfaces so that you are handcuffed to the implementation details.

This was referenced Jun 30, 2015
@ysitu ysitu mentioned this issue Jul 15, 2015
@ysitu
Copy link
Contributor Author

ysitu commented Jul 16, 2015

@OrkoHunter Can you prioritize this?

@OrkoHunter
Copy link
Contributor

Sure. This is a must. I'll be sending a PR shortly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants