Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating prettier in .pre-commit-config.yaml #73

Open
Schefflera-Arboricola opened this issue Aug 4, 2024 · 4 comments
Open

Updating prettier in .pre-commit-config.yaml #73

Schefflera-Arboricola opened this issue Aug 4, 2024 · 4 comments
Labels
type: Bug fix Something isn't working type: Maintenance

Comments

@Schefflera-Arboricola
Copy link
Member

Schefflera-Arboricola commented Aug 4, 2024

The repository we currently use for the prettier hook has been archived.

- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.1.0
hooks:
- id: prettier
files: \.(html|md|toml|yml|yaml)
args: [--prose-wrap=preserve]

I think we should switch to something else.

Thank you :)

[EDIT] - networkx also uses the same archived repository. So, maybe we should consider updating that also.

@MridulS
Copy link
Member

MridulS commented Aug 5, 2024

Maybe we can look if we can get ruff to work with prettier, related astral-sh/ruff#10738

@jarrodmillman
Copy link
Member

We may just want to do this for now: scientific-python/cookie#467

@Schefflera-Arboricola
Copy link
Member Author

We may just want to do this for now: scientific-python/cookie#467

There wasn't any discussions below the PR you(@jarrodmillman) have mentioned. So, how exactly does using this particular fork fixes this issue?

Thank you :)

@Schefflera-Arboricola
Copy link
Member Author

#80 (comment)

adding here for reference; seems related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Bug fix Something isn't working type: Maintenance
Development

No branches or pull requests

3 participants