Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to zoom in/out the timeline when there is at least one selected event #117

Open
zhenghow93 opened this issue Jan 16, 2024 · 3 comments

Comments

@zhenghow93
Copy link

zhenghow93 commented Jan 16, 2024

Whenever there is at least one selected event, the <MouseCursor /> component is hidden, the logic is as shown in line 132 of the file /src/timeline/layers/interaction/Interaction.tsx, hence making zoom-in or zoom-out impossible via mouse click.

Is there a specific reason for this behaviour?
I can resort to pinning the event instead of selecting the event if I still need the zoom to function while having the selected events highlighted, but styling options will be different (I can't assign fillColor pinned events).

@zhenghow93 zhenghow93 changed the title Unable to zoom in the timeline when there is at least one selected event Unable to zoom in/out the timeline when there is at least one selected event Jan 16, 2024
@netzwerg
Copy link
Owner

I honestly don't remember why we changed it this way 🙈 Could it be that selecting events otherwise leads to unintentional zooming?

Feel free to just fork the repository and change the logic according to your needs.

@zhenghow93
Copy link
Author

Thanks for the reply. We did fork it and made quite a number of functional and aesthetic customizations which are configurable via props. I'm asking for permission from my workplace whether it's fine to make a pull request to this repo. It'll be useful for the community

@shivika
Copy link

shivika commented Jun 20, 2024

@zhenghow93 - were you able to get your fork available? I would like to see your customizations as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants