From 537427d5165493f8b0e0ea24ec515aa4e90ae35c Mon Sep 17 00:00:00 2001
From: Rui Azevedo <ruihfazevedo@gmail.com>
Date: Mon, 1 Apr 2019 16:00:53 +0000
Subject: [PATCH] use non-blocking blink example, fix action serialio example
 handler

---
 .gitignore                                     |  2 ++
 examples/Blink/Blink/Blink.ino                 | 15 +++++++--------
 examples/Blink/platformio.ini                  |  2 +-
 examples/Serial/serialio/platformio.ini        |  2 +-
 examples/Serial/serialio/serialio/serialio.ino |  2 +-
 library.properties                             |  2 +-
 6 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/.gitignore b/.gitignore
index c9f5d03a..acc58b18 100644
--- a/.gitignore
+++ b/.gitignore
@@ -17,3 +17,5 @@ examples/clickEncoder
 examples/screenNav
 /dev
 /examples/dev
+/composition_test
+/examples/tiny
diff --git a/examples/Blink/Blink/Blink.ino b/examples/Blink/Blink/Blink.ino
index 7f09afd5..be4b673a 100644
--- a/examples/Blink/Blink/Blink.ino
+++ b/examples/Blink/Blink/Blink.ino
@@ -19,12 +19,12 @@ using namespace Menu;
 #define LEDPIN LED_BUILTIN
 #define MAX_DEPTH 1
 
-int timeOn=10;
-int timeOff=90;
+unsigned int timeOn=10;
+unsigned int timeOff=90;
 
 MENU(mainMenu, "Blink menu", Menu::doNothing, Menu::noEvent, Menu::wrapStyle
-  ,FIELD(timeOn,"On","ms",0,100,10,1, Menu::doNothing, Menu::noEvent, Menu::noStyle)
-  ,FIELD(timeOff,"Off","ms",0,100,10,1,Menu::doNothing, Menu::noEvent, Menu::noStyle)
+  ,FIELD(timeOn,"On","ms",0,1000,10,1, Menu::doNothing, Menu::noEvent, Menu::noStyle)
+  ,FIELD(timeOff,"Off","ms",0,10000,10,1,Menu::doNothing, Menu::noEvent, Menu::noStyle)
   ,EXIT("<Back")
 );
 
@@ -47,10 +47,9 @@ void setup() {
   Serial.println("to control the menu navigation");
 }
 
+bool blink(int timeOn,int timeOff) {return millis()%(unsigned long)(timeOn+timeOff)<(unsigned long)timeOn;}
+
 void loop() {
   nav.poll();
-  digitalWrite(LEDPIN, HIGH);
-  delay(timeOn);
-  digitalWrite(LEDPIN, LOW);
-  delay(timeOff);
+  digitalWrite(LEDPIN, blink(timeOn,timeOff));
 }
diff --git a/examples/Blink/platformio.ini b/examples/Blink/platformio.ini
index d0145b94..c7224ff6 100644
--- a/examples/Blink/platformio.ini
+++ b/examples/Blink/platformio.ini
@@ -16,7 +16,7 @@ src_dir=Blink
 platform = atmelavr
 board = nanoatmega328
 framework = arduino
-upload_port=/dev/ttyUSB*
+upload_port=/dev/ttyUSB1
 upload_flags=-V
 build_flags = -DNODEBUG
 
diff --git a/examples/Serial/serialio/platformio.ini b/examples/Serial/serialio/platformio.ini
index b846d8c6..fd2e0b87 100644
--- a/examples/Serial/serialio/platformio.ini
+++ b/examples/Serial/serialio/platformio.ini
@@ -39,7 +39,7 @@ src_dir=serialio
 platform = atmelavr
 board = nanoatmega328
 framework = arduino
-upload_port=/dev/ttyUSB*
+upload_port=/dev/ttyUSB1
 upload_flags=-V
 build_flags = -DNO_MENU_DEBUG -Wno-strict-aliasing -Wno-sign-compare -Wno-write-strings
 ;
diff --git a/examples/Serial/serialio/serialio/serialio.ino b/examples/Serial/serialio/serialio/serialio.ino
index ca8febe8..0f97542e 100644
--- a/examples/Serial/serialio/serialio/serialio.ino
+++ b/examples/Serial/serialio/serialio/serialio.ino
@@ -32,7 +32,7 @@ result action1(eventMask e) {
   return proceed;
 }
 
-result action2(eventMask e, prompt &item) {
+result action2(eventMask e,navNode& nav,prompt& item) {
   Serial.print(e);
   Serial.print(" action2 executed, quiting menu");
   return quit;
diff --git a/library.properties b/library.properties
index 7ba081d7..adeb1513 100644
--- a/library.properties
+++ b/library.properties
@@ -1,5 +1,5 @@
 name=ArduinoMenu library
-version=4.17.20
+version=4.17.21
 author=Rui Azevedo, ruihfazevedo@gmail.com
 maintainer=neu-rah, ruihfazevedo@gmail.com
 sentence=Generic menu/interactivity system