Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force bagel.tsv to be loaded as string type to avoid unwanted type casting #108

Closed
Tracked by #107
surchs opened this issue Mar 31, 2023 · 0 comments · Fixed by #111
Closed
Tracked by #107

force bagel.tsv to be loaded as string type to avoid unwanted type casting #108

surchs opened this issue Mar 31, 2023 · 0 comments · Fixed by #111
Assignees

Comments

@surchs
Copy link
Contributor

surchs commented Mar 31, 2023

We should force pandas to load bagel.tsv and cast all columns to type str - I don't think this should break anything, but the tests should tell us.

This addresses the issue of pandas implicitly casting values to non-string types (e.g. "True" and "False" being cast to bool), breaking things in unexpected and silent ways.

@surchs surchs moved this to Specify - Done in Neurobagel Mar 31, 2023
@surchs surchs moved this from Specify - Done to Implement - Active in Neurobagel Apr 3, 2023
@surchs surchs self-assigned this Apr 3, 2023
@surchs surchs moved this from Implement - Active to Implement - Done in Neurobagel Apr 3, 2023
@alyssadai alyssadai moved this from Implement - Done to Review - Active in Neurobagel Apr 3, 2023
@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant