Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the xor_xnor experiment tutorial #301

Closed
7 tasks done
bstraus1 opened this issue Oct 12, 2020 · 10 comments
Closed
7 tasks done

Refine the xor_xnor experiment tutorial #301

bstraus1 opened this issue Oct 12, 2020 · 10 comments

Comments

@bstraus1
Copy link
Contributor

bstraus1 commented Oct 12, 2020

Specifically, I will:

  • Update the notebook using Jayanta's notebook
  • Ensure that there are no warnings/unwanted outputs in the notebook (currently there are some)
  • Go line by line with the code, explaining each step
  • Move long functions to a separate .py file to improve readability
  • Restrict sample sizes in the final figure to X>750
  • Remove progress print statements throughout the code
  • Find and replace all "FTE" with "BTE", and vice versa in the last figure
@levinwil
Copy link
Collaborator

@bstraus1
Copy link
Contributor Author

Those three points I've written above.
In my opinion, the current experiment has too large blocks of code. I'll move long functions to a separate file and go line-by-line in the tutorial.

@levinwil
Copy link
Collaborator

Ok. Can you also please fix the following problem:
Screen Shot 2020-10-12 at 1 04 13 PM
The region circled in black should not exist. If we don't have any data from N-XOR, we can't compute anything with respect to N-XOR.

@bstraus1
Copy link
Contributor Author

Ah, so just restrict the x axis to sample sizes >750?

@levinwil
Copy link
Collaborator

Yup!

@levinwil
Copy link
Collaborator

levinwil commented Oct 12, 2020

@bstraus1 Could you also please get rid of all the progress print statements in the notebook?

@bstraus1
Copy link
Contributor Author

Yep!

@levinwil
Copy link
Collaborator

Can you also switch the labels for FTE and BTE?

@levinwil
Copy link
Collaborator

@bstraus1 Can you please update the original checklist at the top of this issue to include the changes mentioned in the comments?

@bstraus1
Copy link
Contributor Author

This issue can now be closed @levinwil. Sorry that I can't do this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants