Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelize Gini impurity calculation for ObliqueSplitter #416

Merged
merged 5 commits into from
Jan 13, 2021
Merged

Parallelize Gini impurity calculation for ObliqueSplitter #416

merged 5 commits into from
Jan 13, 2021

Conversation

eigenvivek
Copy link
Collaborator

Reference issue

Closes #415

Type of change

Feature Request

What does this implement/fix?

  • Parallelizes calculation of Gini impurity for potential splits using joblib
  • Adds workers, an argument for specifying number of cores to parallelize the calculation of Gini impurity

Additional information

@eigenvivek eigenvivek changed the title Parallelize Gini impurity calculation for oblique splitter Parallelize Gini impurity calculation for ObliqueSplitter Jan 13, 2021
@PSSF23 PSSF23 linked an issue Jan 13, 2021 that may be closed by this pull request
Parallelize Gini impurity calculation for oblique splitter #415
Closed
PSSF23
PSSF23 reviewed Jan 13, 2021
View reviewed changes
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v715 Before my commit, the workers variable was not used in the parallelization. Please check if I have followed your intentions~

@eigenvivek
Copy link
Collaborator Author

Thanks for catching that! Everything works as intended.

PSSF23
PSSF23 approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@PSSF23 PSSF23 merged commit 1ffe82c into neurodata:staging Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSSF23 PSSF23 PSSF23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parallelize Gini impurity calculation for oblique splitter
2 participants
@eigenvivek @PSSF23