Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected indentations in movement.validators.files.ValidVIATracksCSV docs #252

Closed
lochhh opened this issue Jul 30, 2024 · 4 comments · Fixed by #251
Closed

Unexpected indentations in movement.validators.files.ValidVIATracksCSV docs #252

lochhh opened this issue Jul 30, 2024 · 4 comments · Fixed by #251
Labels
bug Something isn't working

Comments

@lochhh
Copy link
Collaborator

lochhh commented Jul 30, 2024

Describe the bug
In #219 docs build succeeds with the following warnings (and errors):

movement\movement\validators\files.py:docstring of movement.validators.files.ValidVIATracksCSV.csv_file_contains_tracked_bboxes:6: ERROR: Unexpected indentation.
movement\movement\validators\files.py:docstring of movement.validators.files.ValidVIATracksCSV.csv_file_contains_tracked_bboxes:7: WARNING: Block quote ends without a blank line; unexpected unindent.
movement\movement\validators\files.py:docstring of movement.validators.files.ValidVIATracksCSV.csv_file_contains_valid_frame_numbers:5: ERROR: Unexpected indentation.
movement\movement\validators\files.py:docstring of movement.validators.files.ValidVIATracksCSV.csv_file_contains_valid_frame_numbers:6: WARNING: Block quote ends without a blank line; unexpected unindent.

While this has since been rectified in #245, the documentation is not rendering as intended (see example screenshot below).

Screenshots
image

@lochhh lochhh added the bug Something isn't working label Jul 30, 2024
@niksirbi niksirbi moved this from 🤔 Triage to 🚧 In Progress in movement progress tracker Jul 30, 2024
@niksirbi
Copy link
Member

Thanks for catching (and fixing) this!

@sfmig
Copy link
Contributor

sfmig commented Aug 1, 2024

thanks @lochhh!

I was confused about this actually... do you know why the doc building succeeds even if there are errors? Should we change this behaviour (is it possible)?

@lochhh
Copy link
Collaborator Author

lochhh commented Aug 1, 2024

thanks @lochhh!

I was confused about this actually... do you know why the doc building succeeds even if there are errors? Should we change this behaviour (is it possible)?

Here it says build succeeded with warnings - only when we look into the warnings, we see that there are "errors". If we think warnings are overly permissive, there is the --fail-on-warning flag to treat warnings as errors, causing build to fail.

@github-project-automation github-project-automation bot moved this from 🚧 In Progress to ✅ Done in movement progress tracker Aug 1, 2024
@sfmig
Copy link
Contributor

sfmig commented Aug 2, 2024

I found a relevant open issue in sphinx-docs here.

It feels a bit annoying...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

3 participants