Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBMA estimators resampling input (potentially non-optimally) #438

Closed
jdkent opened this issue Feb 4, 2021 · 0 comments · Fixed by #439
Closed

IBMA estimators resampling input (potentially non-optimally) #438

jdkent opened this issue Feb 4, 2021 · 0 comments · Fixed by #439
Labels
bug Issues noting problems and PRs fixing those problems. ibma Issues/PRs pertaining to image-based meta-analysis

Comments

@jdkent
Copy link
Member

jdkent commented Feb 4, 2021

Summary

when preprocessing the input for IBMA, the input images are resampled to match the masker object (through the transform).
nilearn's resampling function default options may not be optimal for meta-analytic maps.

For example, some code from @tyarkoni:
resample_to_img(nb.load(img), template, clip=True, interpolation='linear')

deviates from the defaults interpolation='continuous' and clip=False.
Changing those defaults appears to give the maps being analyzed a more biologically plausible result.

Additional details

  • NiMARE version: dev

What were you trying to do?

add nimare to the neuroscout paper

What did you expect to happen?

biologically plausible results conformant to previous analyses with PyMare

What actually happened?

weird pixelated results

@jdkent jdkent added the bug Issues noting problems and PRs fixing those problems. label Feb 4, 2021
@jdkent jdkent added the ibma Issues/PRs pertaining to image-based meta-analysis label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems. ibma Issues/PRs pertaining to image-based meta-analysis
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant