If NeuroVault collection doesn't contain effect request, error is somewhat cryptic

[adelavega]

NiMARE/nimare/io.py

Line 544 in 05bbd89

sample_size = sample_sizes[0]

Minor issue, if you request a NeuroVault image from a collection and there is no match, the error is fairly cryptic (IndexError I believe).

[tsalo]

Would something like the following work right before the sample_sizes check?

if all(not v for v in dataset_dict[f"study-{coll_name}"]["contrasts"][contrast_name]["images"].values()):
    LGR.warning(f"No valid images found for collection {coll_name} contrast {contrast_name}")
    continue

[adelavega]

Yes, and or just an exception. Probably it shouldn't continue if after the for loop no images are found. Or at least it should not try to check sample_sizes since it will be an empty list.

[tsalo]

Oh wait... @jdkent's changes in #580 will solve this issue, I think. He went with an exception.

[adelavega]

Hah! I'm even on that branch but 24 hours too old

[jdkent]

closed with #580!