Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Dependency deprecation warning: stylelint-processor-html (npm) #982

Closed
renovate bot opened this issue Jul 5, 2018 · 7 comments
Closed

Dependency deprecation warning: stylelint-processor-html (npm) #982

renovate bot opened this issue Jul 5, 2018 · 7 comments

Comments

@renovate
Copy link
Contributor

renovate bot commented Jul 5, 2018

On registry https://registry.npmjs.org/, the "latest" version (v1.0.0) of dependency stylelint-processor-html has the following deprecation notice:

Please use stylelint-processor-arbitrary-tags https://github.com/mapbox/stylelint-processor-arbitrary-tags

Marking the latest version of an npm package as deprecated results in the entire package being considered deprecated, so contact the package author you think this is a mistake.

Please take the actions necessary to rename or substitute this deprecated package and commit to your base branch. If you wish to ignore this deprecation warning and continue using stylelint-processor-html as-is, please add it to your ignoreDeps array in Renovate config before closing this issue, otherwise another issue will be recreated the next time Renovate runs.

@edmorley
Copy link
Member

@timkelty, would you be able to take this? :-)

@timkelty
Copy link
Contributor

Yep! I'm on it!

@edmorley
Copy link
Member

Hi @timkelty, hope you are well :-) Do you know if you'll have a chance to look at this?

Just to give a heads up - the stylelint preset is one of the presets that falls into the category of "not maintained and very low usage" (2K total downloads vs 1 million for Neutrino core), and so is at risk of being demoted from the monorepo if we're not able to get more people helping out to maintain it.

@timkelty
Copy link
Contributor

Thanks for the kick @edmorley! Been meaning to get to this and has just fell through the cracks. Should be able to this week for sure. If not, my fault if it gets axed :)

@timkelty
Copy link
Contributor

timkelty commented Aug 30, 2018

FWIW I did a little digging and it looks like this isn't so much an issue with the stylelint middleware, but with the Vue middleware that was added later (3d253ae#diff-8e01b2cd41edef3f12c383a2371bc95bR39).

It looks like we could switch over to stylelint-processor-arbitrary-tags easily enough, but I'm also not thrilled with how this integration works right now…e.g. if will stop linting and css files and only look for *.vue, and also won't pick up things like <style src="./foo.css"></style> in *.vue files.

@helfi92 any thoughts?

@edmorley
Copy link
Member

edmorley commented Sep 5, 2018

Ah sorry for not spotting it was added later :-)

@timkelty
Copy link
Contributor

timkelty commented Sep 5, 2018

NP – Still related, and of interest to me, so I'll try and jump on it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants