Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize the different Analyzer #25

Closed
jeremi opened this issue Dec 25, 2020 · 0 comments · Fixed by #35
Closed

Reorganize the different Analyzer #25

jeremi opened this issue Dec 25, 2020 · 0 comments · Fixed by #35
Assignees
@rjmangubat23
Labels
enhancement New feature or request
Milestone
0.3

Comments

@jeremi
Copy link
Member

jeremi commented Dec 25, 2020

There are too many unnecessary branches in the code, we need to create an Analyser Interface that implement each of the AnalyzerType.
@jeremi jeremi added the enhancement New feature or request label Dec 25, 2020
@jeremi jeremi added this to the 0.2 milestone Dec 25, 2020
@rjmangubat23 rjmangubat23 mentioned this issue Jan 15, 2021
Merged
@rjmangubat23 rjmangubat23 linked a pull request Jan 15, 2021 that will close this issue
Reorganize the different Analyzer #35
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjmangubat23 rjmangubat23

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3
Development

Successfully merging a pull request may close this issue.

Reorganize the different Analyzer newlogic/smartscanner-core
2 participants
@jeremi @rjmangubat23