Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support org.apache.kafka:kafka-clients 3.0.0 and above #456

Closed
XiXiaPdx opened this issue Sep 24, 2021 · 3 comments
Closed

Support org.apache.kafka:kafka-clients 3.0.0 and above #456

XiXiaPdx opened this issue Sep 24, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@XiXiaPdx
Copy link
Contributor

XiXiaPdx commented Sep 24, 2021

   > Verification FAILED. Instrumentation module kafka-clients-metrics-0.10.0.0-1.0.jar SHOULD HAVE applied to org.apache.kafka:kafka-clients:3.0.0 and did not. You may need to adjust the range "org.apache.kafka:kafka-clients:[0.10.0.0,)".
     Verifier output:
     Creating user classloader with custom classpath:
     	/home/jenkins/.gradle/caches/modules-2/files-2.1/org.apache.kafka/kafka-clients/3.0.0/5301db5e9ad9f17da85a4dec06e1d313071dc9d8/kafka-clients-3.0.0.jar
     	/home/jenkins/.gradle/caches/modules-2/files-2.1/com.github.luben/zstd-jni/1.5.0-2/52fc9e353b4e84f8a87ebc9c5c59e58c91d5d23d/zstd-jni-1.5.0-2.jar
     	/home/jenkins/.gradle/caches/modules-2/files-2.1/org.lz4/lz4-java/1.7.1/c4d931ef8ad2c9c35d65b231a33e61428472d0da/lz4-java-1.7.1.jar
     	/home/jenkins/.gradle/caches/modules-2/files-2.1/org.xerial.snappy/snappy-java/1.1.8.1/d30aaf4d41d6ff0c760c8931d3b8dafc0293c91a/snappy-java-1.1.8.1.jar
     	/home/jenkins/.gradle/caches/modules-2/files-2.1/org.slf4j/slf4j-api/1.7.30/b5a4b6d16ab13e34a88fae84c35cd5d68cac922c/slf4j-api-1.7.30.jar
     ReferenceViolation{type=INVALID_REFERENCE, weaveClass=com/nr/instrumentation/kafka/NewRelicMetricsReporter$1, originalClass=org/apache/kafka/common/metrics/KafkaMetric, violationMessage=missing method. weave code expects method: value()D}

Add instrumentation that supports newer versions.

@XiXiaPdx XiXiaPdx added the enhancement New feature or request label Sep 24, 2021
@meiao
Copy link
Contributor

meiao commented Feb 18, 2022

This has been implemented with the instrumentation module com.newrelic.instrumentation.kafka-clients-metrics-2.0.0.
Actually that module is an add on to the 0.10.0.0 instrumentation module and only adds instrumentation to one method that did not exist in versions prior to 2.0.0.

@meiao meiao closed this as completed Feb 18, 2022
@averkhovtsev-xm
Copy link
Contributor

#713

@meiao
Copy link
Contributor

meiao commented Feb 22, 2022

Support for 3.0.0 is in the module com.newrelic.instrumentation.kafka-clients-metrics-2.0.0. There are gaps though. See #711.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants