Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all instrumentation related config values after dependency detection to convert "auto" to "prepend" or "chain" #1924

Closed
fallwith opened this issue Apr 6, 2023 · 1 comment · Fixed by #1930
Assignees

Comments

@fallwith
Copy link
Contributor

fallwith commented Apr 6, 2023

Our instrumentation.* params, such as instrumentation.net_http currently support four possible values: disabled, auto, prepend, and chain.

The auto value (the default) sees the agent attempt to dynamically determine whether method prepending or chaining should be used. After this automated determination has been made and the relevant method(s) have been updated, it would be great to be able to query the agent configuration afterwards and introspect whether "chain" or "prepend" was selected.

Given that the "auto" value serves no purpose post dependency detection time, is the default, and can't be set via a server side configuration change, it might be best to simply convert the "auto" value into either a "prepend" or "chain" value so that querying the config for any given instrumentation will expose the method updating approach that was taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant