Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message shim to handle inserting headers on n messages in a producer #2245

Closed
bizob2828 opened this issue Jun 4, 2024 · 1 comment · Fixed by #2250
Closed

Update message shim to handle inserting headers on n messages in a producer #2245

bizob2828 opened this issue Jun 4, 2024 · 1 comment · Fixed by #2250
Assignees
Labels
points: 5 1-2 weeks

Comments

@bizob2828
Copy link
Member

bizob2828 commented Jun 4, 2024

Description

Kafkajs allows you to send multiple messages in 1 send call. Our message-shim only adds headers to one message. Our current approach is to just DT headers to the first message.

Acceptance Criteria

As a kafkajs user I want the ability to include DT headers when sending multiple messages in a producer.send or producer.sendBatch call.

Additional context

Here's a poc branch that adds a new function to handle returning all the headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
points: 5 1-2 weeks
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants