-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): revert #11050 #11469
fix(core): revert #11050 #11469
Conversation
Added a test to avoid regression
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11469 +/- ##
=======================================
Coverage ? 40.02%
=======================================
Files ? 179
Lines ? 28682
Branches ? 1258
=======================================
Hits ? 11481
Misses ? 17201
Partials ? 0 ☔ View full report in Codecov by Sentry. |
* fix(core): revert nextauthjs#11050 Added a test to avoid regression * Update callback.test.ts * Update index.ts
but thre were problem, if we use the |
@TruongNam0301 Same error here. No metter what error is thrown, I always get 'Configuration' |
Same thing here, any luck @manishoctal @TruongNam0301 |
Not yet!! |
Really? |
in #11050 we accidentally introduced a regression issue for the
authorize
function of theCredentialProvider
. Returningnull
in this callback is now throwing aConfigurationError
which should not be the case.This PR reverts the changes in #11050 and adds some tests to avoid regressing in the future.
Fixes #11074 #11190 #11428