Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding mysql-adapter #11856

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

adding mysql-adapter #11856

wants to merge 5 commits into from

Conversation

MAHB98
Copy link

@MAHB98 MAHB98 commented Sep 16, 2024

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@MAHB98 MAHB98 requested review from 0ubbe and ndom91 as code owners September 16, 2024 23:43
Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Feb 26, 2025 1:28pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 1:28pm

Copy link

vercel bot commented Sep 16, 2024

@MAHB98 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the adapters Changes related to the core code concerning database adapters label Sep 16, 2024
Copy link

@bherila bherila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits to suggest but I am planning on adopting this myself to avoid pulling a heavy-weight ORM into my own project.

"url": "git+https://github.com/MAHB98/mysql-adapter.git"
},
"keywords": [

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove blank line

"author": "MAHB98",
"license": "ISC",
"bugs": {
"url": "https://github.com/MAHB98/mysql-adapter/issues"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL doesn't exist- remove or replace with this repo's issues

"tslib": "^2.6.3"
},
"devDependencies": {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra line

"homepage": "https://github.com/MAHB98/mysql-adapter#readme",
"dependencies": {
"@auth/core": "^0.34.1",
"tsc": "^2.0.4",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsc is deprecated

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i remove tsc from dependencies and repositories is now in place

@bherila
Copy link

bherila commented Dec 31, 2024

Personally I would love to have this, although it'd also be nice if it were updated to support the new passkeys/webauthn functionality.

const { id, name, email, emailVerified, image } = newUser;
const updateSql = `
UPDATE users set
name =?, email = ?, emailVerified = ?, image = ?
Copy link

@yedidyar-ni yedidyar-ni Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name =?, email = ?, emailVerified = ?, image = ?
name = ?, email = ?, emailVerified = ?, image = ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it will break without it

update delete user

Co-authored-by: Yedidya Rashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants