rename adapter.ts -> adapters.ts in @auth/sveltekit
#12503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package.json exports ./adapters, consistent with other packages. This meant it was not accessible for consumption when the source file and exported files didn't match.
|
@emme1444 is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12503 +/- ##
=======================================
Coverage 39.42% 39.42%
=======================================
Files 198 198
Lines 31285 31285
Branches 1370 1376 +6
=======================================
Hits 12334 12334
Misses 18951 18951 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package.json exports ./adapters, consistent with other packages. This meant it was not accessible for consumption when the source file and exported files didn't match.
☕️ Reasoning
I could not
import * from "@auth/sveltekit/adapters", and noticed that the source file was calledadapter.ts(singular) but thepackage.jsonexpected a types export file calledadapters.d.ts(plural).As stated above, this PR simply renames the
adapter.tsfile toadapters.ts. I chose to rename the file in order to be consistent with the rest of the project.If I have greatly misunderstood something simple here, please let me know.
Also let me know if there are other changes needed as a result of these changes. (I couldn't think of any)
🧢 Checklist
🎫 Affected issues
I couldn't find any issues on this and I didn't create one since I though it was a small enough problem not worth an issue. If you would like me to open an issue I could do that ASAP.
📌 Resources