Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add support for SameSite cookie attribute with useStrictCookies option #12708

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

k-taro56
Copy link
Contributor

@k-taro56 k-taro56 commented Feb 26, 2025

☕️ Reasoning

Introduce support for the SameSite cookie attribute based on the useStrictCookies option, enhancing cookie security configurations

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@k-taro56 k-taro56 requested a review from ThangHuuVu as a code owner February 26, 2025 05:35
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 6:18am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 6:18am

Copy link

vercel bot commented Feb 26, 2025

@k-taro56 is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.50%. Comparing base (af2ccea) to head (cb6b32a).

Files with missing lines Patch % Lines
packages/core/src/jwt.ts 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12708      +/-   ##
==========================================
+ Coverage   39.46%   39.50%   +0.04%     
==========================================
  Files         198      198              
  Lines       31306    31333      +27     
  Branches     1372     1381       +9     
==========================================
+ Hits        12354    12379      +25     
- Misses      18952    18954       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant