Fix default multiselect height #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
bug
skjnldsv
requested review from
PVince81,
ChristophWurst,
juliusknorr,
GretaD and
marcoambrosini
skjnldsv
force-pushed
the
fix/multiselect-height
branch
3 times, most recently
from
e770654 to
b9d818e
Compare
juliusknorr
approved these changes
Nov 18, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
skjnldsv
force-pushed
the
feat/ListItemIcon
branch
3 times, most recently
from
22f6f21 to
dc9de62
Compare
This comment has been minimized.
This comment has been minimized.
skjnldsv
force-pushed
the
fix/multiselect-height
branch
from
b9d818e to
bfaf9dd
Compare
|
|
PVince81
approved these changes
Nov 26, 2020
| @@ -189,8 +198,11 @@ export default { | |||
| }, | |||
|
|
|||
| cssVars() { | |||
| // Don't use margin to calculate the height if noMargin | |||
| const margin = this.noMargin ? 0 : this.margin | |||
There was a problem hiding this comment.
why not take "margin='0'" as property for disabling ? probably we don't want people supplying custom margins I guess ?
There was a problem hiding this comment.
probably we don't want people supplying custom margins I guess ?
Yep :/
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
fix/multiselect-height
branch
from
bfaf9dd to
e4b04db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To review before: #1578
Switched to standard positioning to make sure the container take the content's height.
Allows design like this