Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop Icon on budgie-desktop very big #3322

Closed
git001 opened this issue May 15, 2021 · 7 comments
Closed

Desktop Icon on budgie-desktop very big #3322

git001 opened this issue May 15, 2021 · 7 comments
Labels

Comments

@git001
Copy link

git001 commented May 15, 2021

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Expected behaviour

The nextcloud Icon should be scaled to the taskbar size and not other way around.

Actual behaviour

With the update of nextcloud desktop to 3.2 is the Icon in the task bar very big and does not scale to the taskbar size.

2021-05-15_23-19-14_Nextcloud-Icon

uname -a
Linux alex-TUXEDO-Book-XP1511 5.8.0-50-generic #56~20.04.1-Ubuntu SMP Mon Apr 12 21:46:35 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
/usr/bin/budgie-desktop --version
budgie-desktop 10.5.1
Copyright © 2014-2019 Budgie Desktop Developers

I have to increase the "size" for the bottom task bar to 60 to see the other icons

2021-05-15_23-24-50_Budgie-Desktop-Settings

Steps to reproduce

  1. run budgie-desktop
  2. run nextcloud desktop 3.2

Client configuration

Client version:

/home/alex/Downloads/Nextcloud-3.2.1-x86_64.AppImage --version
Nextcloud version 3.2.1git (build 5546)
Git revision 5901a0f9835261a640cd8bc9397bcd3068f2acd8
Using Qt 5.12.9, built against Qt 5.12.9
Using Qt platform plugin 'xcb'
Using 'OpenSSL 1.1.1g  21 Apr 2020'
Running on Ubuntu 20.04.2 LTS, x86_64

Operating system: 20.04.1-Ubuntu

OS language:

# locale
LANG=en_US.UTF-8
LANGUAGE=
LC_CTYPE="en_US.UTF-8"
LC_NUMERIC=de_AT.UTF-8
LC_TIME=de_AT.UTF-8
LC_COLLATE="en_US.UTF-8"
LC_MONETARY=de_AT.UTF-8
LC_MESSAGES="en_US.UTF-8"
LC_PAPER=de_AT.UTF-8
LC_NAME=de_AT.UTF-8
LC_ADDRESS=de_AT.UTF-8
LC_TELEPHONE=de_AT.UTF-8
LC_MEASUREMENT=de_AT.UTF-8
LC_IDENTIFICATION=de_AT.UTF-8
LC_ALL=

Qt version used by client package (Linux only, see also Settings dialog): 5.12.9

Client package (From Nextcloud or distro) (Linux only): AppImage

Installation path of client: /home/alex/Downloads/

Server configuration

not necessary for this issue.

Logs

Please use Gist (https://gist.github.com/) or a similar code paster for longer
logs.

  1. Client logfile:
    Because it's a client Issue I don't think that the client logs are required here.

  2. Web server error log:

  3. Server logfile: nextcloud log (data/nextcloud.log):

@git001 git001 added the bug label May 15, 2021
@FlexW
Copy link

FlexW commented May 17, 2021

It's probably a problem of budgie not the desktop client. I don't have this problem with other status bars on different Linux Distributions.

@fossfreedom
Copy link

This is a Qt issue together with the icon size next cloud is presenting to the appindicator.

Discussion here for a similar Qt issue UbuntuBudgie/budgie-indicator-applet#18

@FlexW
Copy link

FlexW commented May 17, 2021

@fossfreedom Thanks for pointing this out. I don't know where I can find the appindicator spec on the internet, or if there even is one. I'm only aware of the sni specification which I think is the "official" tray icon specification on Linux. The specification does not talk about that icons should be send in a specified size (which makes sense in my opinion, because the application does not know how big or small the status bar is). I'm not sure if we can do anything about this issue. Please tell me if I'm wrong or missing something :)

P.S.: I have just seen the tray icon implementation for swaybar, but they simply scale the icons to the right size. Maybe budgie should do the same.

EDIT: According to the Qt documentation, Qt implements the SNI specification. https://doc.qt.io/qt-5/qsystemtrayicon.html

@fossfreedom
Copy link

appindicators / ayatana indicators should be 16px - 24px for .png images - for .svg images they are autosized (normally).

No - we don't fiddle with appindicator images - that is up to the implementator (appindicator creator) - images can be - for example - very wide.

@git001
Copy link
Author

git001 commented May 17, 2021

Thanks for all answers.
After a reboot of the machine and the new Version is the Icon now normal.
I don't know if the reboot or the new version was the fix, but now is the size back to "40" and the icon is similar small as all other icons

@git001 git001 closed this as completed May 17, 2021
@dreamcat4
Copy link

hey there, i think there is a bug in budgie here in a different sense:

  • when this app indicator bug occurs (not budgie fault) it may occur in the app indicator, before budgie gets the icon butmap images to render
  • then the budgie panel automatically grows itself larger, to accomodate the smallest size of the largest icon to display. which is the bugged icon here in this case. ok we understand that now. ok.
  • however this 'auto resize' size is now different (and larger) than the pixel size of the user setting which the user already specified in budgie control panel settings
  • ok... so why is that a bug?
  • its a bug in budgie that the other windows next to the panel are all still snapping to the user specificed panel height. which is no longer true. so then the panel and the snapped window(s) overlaps each other
  • if budgie changed the height of the panel (for whatever reason), then maybe budgie should update its internal windows running state more properly elsewhere, to reflect and calculate based on the actual (real) panel height. not the user specified panel height

ok so you can argue also an option for the user to 'force the panel height' respect it. then the too large icons will be cut off and occluded etc. either way its a buggy situation.

so in my next post i shall talk about addressing the real (root cause) bug. because that is more important thing we need to be fixing. it's just the real bug revealed another hidden bug elsewhere that's all

@dreamcat4
Copy link

ok so what happened to me today?

  • upgraded from 20.04 --> 21.04
  • noticed the svg icons resizing bug happen again
  • looked at the new svg icon in question
  • looked at the old svg icon in question

they are different SVG files to each other, but both of them exhibits a similar issue. icon too big. So why? well in the 1st icon you can see here there is a property viewBox="0 0 48 48"... well the SVG icon is rendered at 48 pixels sizing. Too big! It needs to render at 22px or 24px whatever.

OK so that was the new icon. What about the old icon? Well that one was huge. It rendered at over 100px icon size. So was it the same SVG property fault? No! it was <svg enable-background="new" height="102.4" width="102.4". Which is different svg property name. But similar.

ah ok, so just edit the properties, bad svg right? Well it does demonstrate the issue here: if i edit the new icon, and make it viewBox="0 0 24 24" instead of 48 px, the icon now is smaller! Great! But wait...

it seems all of the instructions in the SVG is all based of 48 pixels geometries. So when I change the outside box size to 24px (or 22px whatever). The other draw instructions in the svg are not changed. So it only displays 1/4 of the icon. The rest is cut (cropped) off. And not actually scaled.

So the real solution I'm still not sure. However we can see a 'workaround' at least. Given that the QT bug might be harder to fix. At least we can get by until then. The question now is well.... how do i convert the bad SVG icon?

Maybe the problem is because the top level 1st <svg> parent tag has these 'master' property. Which is then noticed by QT. So perhaps we don't need to rewrite whole SVG geometries (difficult). If we can instead just move the property out of the toplevel tag. So it does not 'trigger' QT. But still exists there in some child nodes. Like <div> in HTML. However IDK if that is works.

Also IDK where is the spec for compliant SVG icons. If you know please link it. Many thanks.

new svg icon:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 48 48">
 <defs>
  <linearGradient id="linearGradient3764" x1="1" x2="47" gradientUnits="userSpaceOnUse" gradientTransform="matrix(0,-1,1,0,-1.5e-6,47.999998)">
   <stop style="stop-color:#575757;stop-opacity:1"/>
   <stop offset="1" style="stop-color:#616161;stop-opacity:1"/>
  </linearGradient>
 </defs>
 <g>
  <path d="m 36.31 5 c 5.859 4.062 9.688 10.831 9.688 18.5 c 0 12.426 -10.07 22.5 -22.5 22.5 c -7.669 0 -14.438 -3.828 -18.5 -9.688 c 1.037 1.822 2.306 3.499 3.781 4.9>
  <path d="m 41.28 8.781 c 3.712 4.085 5.969 9.514 5.969 15.469 c 0 12.703 -10.297 23 -23 23 c -5.954 0 -11.384 -2.256 -15.469 -5.969 c 4.113 3.854 9.637 6.219 15.719 >
  <path d="m 31.25 2.375 c 8.615 3.154 14.75 11.417 14.75 21.13 c 0 12.426 -10.07 22.5 -22.5 22.5 c -9.708 0 -17.971 -6.135 -21.12 -14.75 a 23 23 0 0 0 44.875 -7 a 23 >
 </g>
 <g>
  <path d="m 24 1 c 12.703 0 23 10.297 23 23 c 0 12.703 -10.297 23 -23 23 -12.703 0 -23 -10.297 -23 -23 0 -12.703 10.297 -23 23 -23 z" style="fill:url(#linearGradient3>
 </g>
 <g>
  <path d="m 40.03 7.531 c 3.712 4.084 5.969 9.514 5.969 15.469 0 12.703 -10.297 23 -23 23 c -5.954 0 -11.384 -2.256 -15.469 -5.969 4.178 4.291 10.01 6.969 16.469 6.96>
 </g>
 <path d="m 22.272 17 c -3.521 -0.004 -6.094 2.696 -7.739 5.841 -2.144 4.098 -4.406 10.155 -0.041 10.155 4.594 0 8.411 -2.55 11.11 -4.477 0.979 1.785 2.404 4.477 4.395>
 <path d="m 21.272 16 c -3.521 -0.004 -6.094 2.696 -7.739 5.841 -2.144 4.098 -4.406 10.155 -0.041 10.155 4.594 0 8.411 -2.55 11.11 -4.477 0.979 1.785 2.404 4.477 4.395>
</svg>

old svg icon (which was of my original before times issues, months back):

<svg enable-background="new" height="102.4" width="102.4" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"><linearGradient id="a" gradientUnits="userSpaceOnUse" x1="51.2000016" x2="51.2000016" y1="96.000003" y2="6.38689855"><stop offset="0" stop-color="#404040"/><stop offset="1" stop-color="#808080"/></linearGradient><radialGradient id="b" cx="48" cy="-14.78724" gradientTransform="matrix(0 1.0591161 -1.0684903 0 35.399977 -44.324099)" gradientUnits="userSpaceOnUse" r="42"><stop offset="0" stop-color="#a0a0a0"/><stop offset="1" stop-color="#a0a0a0" stop-opacity="0"/></radialGradient><linearGradient id="c" gradientUnits="userSpaceOnUse" x1="38.78095375" x2="38.78095375" y1="6.4000002" y2="68.152688"><stop offset="0" stop-color="#fff"/><stop offset="1" stop-color="#fff" stop-opacity="0"/></linearGradient><linearGradient id="d" gradientTransform="matrix(1.0058652 0 0 .994169 100 0)" gradientUnits="userSpaceOnUse" x1="45.447727" x2="45.447727" y1="92.539597" y2="7.0165396"><stop offset="0"/><stop offset="1" stop-opacity=".58823532"/></linearGradient><linearGradient id="e" gradientTransform="matrix(1.0920635 0 0 -1.0793651 -1.2190476 104.60952)" gradientUnits="userSpaceOnUse" x1="32.251034" x2="32.251034" xlink:href="#d" y1="6.1317081" y2="90.238609"/><linearGradient id="f" gradientTransform="matrix(1.0920635 0 0 1.0793651 -1.2190476 -104.60952)" gradientUnits="userSpaceOnUse" x1="32.251034" x2="32.251034" xlink:href="#d" y1="6.1317081" y2="90.238609"/><linearGradient id="g" gradientTransform="matrix(1.0666667 0 0 1.0666667 0 -103.46667)" gradientUnits="userSpaceOnUse" x1="32.251034" x2="32.251034" xlink:href="#d" y1="6.1317081" y2="90.238609"/><path d="m12.8 101.36667c-5.8784963 0-10.7-4.821507-10.7-10.700003v-75.733334c0-5.8784959 4.8215038-10.6999997 10.7-10.6999997h76.8c5.878496 0 10.7 4.8215037 10.7 10.6999997v75.733334c0 5.878496-4.821504 10.700003-10.7 10.700003z" fill="url(#e)" opacity=".07999998"/><path d="m12.8 100.3c-5.3030752 0-9.6333333-4.330258-9.6333333-9.633333v-75.733334c0-5.3030748 4.3302582-9.633333 9.6333333-9.633333h76.8c5.303075 0 9.633333 4.3302581 9.633333 9.633333v75.733334c0 5.303075-4.330258 9.633333-9.633333 9.633333z" fill="url(#e)" opacity=".1"/><path d="m12.8 99.2c-4.7030755 0-8.5333333-3.830258-8.5333333-8.533333v-75.733334c0-4.703075 3.8302578-8.533333 8.5333333-8.533333h76.8c4.703075 0 8.533333 3.830258 8.533333 8.533333v75.733334c0 4.703075-3.830258 8.533333-8.533333 8.533333z" fill="url(#e)" opacity=".2"/><rect fill="url(#f)" height="90.666664" opacity=".3" rx="7.4666667" transform="scale(1 -1)" width="91.73333" x="5.3333335" y="-98.133331"/><rect fill="url(#g)" height="89.599998" opacity=".45" rx="6.4000001" transform="scale(1 -1)" width="89.599998" x="6.4000001" y="-97.066666"/><path d="m12.8 6.4c-3.5456 0-6.4 2.8544-6.4 6.4v2.133333 72.533334 2.133333c0 .357036.044107.69408.1 1.033333.051947.315303.1035093.63671.2.933334.010539.03241.022285.06784.033333.1.105456.306955.2505389.583948.4.866666.1542313.291741.3366572.571323.5333334.833334.1966764.26201.3986952.505036.6333336.733333.4692768.456593 1.0057707.868828 1.6 1.166667.297115.148919.611705.26341.933333.366666-.273282-.106903-.519158-.252023-.766666-.4-.0079-.0047-.02546.0048-.03333 0-.034061-.02059-.066446-.04534-.1-.06667-.128425-.08181-.2464278-.17441-.3666703-.266663-.113251-.086187-.2274997-.171853-.3333334-.266667-.1897919-.172195-.3706235-.368414-.5333333-.566666-.1147508-.138939-.2329535-.282971-.3333333-.433334-.0267616-.040938-.0410091-.091594-.0666667-.133333-.0690805-.109901-.1389093-.218151-.2-.333333-.1077422-.207687-.2193865-.443415-.3-.666667-.0084907-.023264-.0251616-.043253-.0333333-.066667-.0339468-.09808-.0381915-.199286-.0666667-.3-.0323545-.113726-.075082-.216566-.1-.333333-.0777372-.364279-.1333333-.744752-.1333333-1.133333v-2.133334-72.533333-2.133333c0-2.967305 2.3660284-5.3333337 5.3333333-5.3333337h2.133333 72.533334 2.133333c2.967305 0 5.333333 2.3660287 5.333333 5.3333337v2.133333 72.533333 2.133334c0 .388581-.05559.769054-.133333 1.133333-.04709.220686-.09427.424169-.166667.633333-.0082.02341-.02485.0434-.03333.06667-.06692.185322-.147609.391946-.233333.566667-.04435.08832-.08431.181284-.133334.266666-.05824.103691-.135225.200907-.2.3-.100384.150363-.218582.294395-.333333.433334-.152719.18608-.32335.370131-.5.533333-.01192.01088-.02131.02256-.03333.03333-.147618.133927-.304103.250065-.466673.366667-.109409.07803-.217939.163588-.333333.233333-.0079.0048-.02543-.0047-.03333 0-.247508.147977-.493384.293097-.766666.4.321624-.103253.636214-.217747.933329-.366666.594229-.297839 1.130723-.710074 1.6-1.166667.234638-.228297.436657-.471323.633333-.733333.196677-.262011.379102-.541593.533334-.833334.149461-.282718.294544-.559711.4-.866666.0111-.03283.02275-.06692.03333-.1.09649-.296624.148053-.618031.2-.933334.055896-.339253.100003-.676297.100003-1.033333v-2.133333-72.533334-2.133333c0-3.5456-2.8544-6.4-6.4-6.4z" fill="url(#c)" opacity=".4"/><rect fill="url(#a)" height="89.599998" rx="6.4000001" width="89.599998" x="6.4000001" y="6.4000001"/><path d="m12.8 6.4c-3.5456 0-6.4 2.8544-6.4 6.4v38.4h89.6v-38.4c0-3.5456-2.8544-6.4-6.4-6.4z" fill="url(#b)" opacity=".8"/><g stroke="#0cc" stroke-opacity=".15686275"><path d="m90.120937 55.223446c-10.769328 13.49115-.336437.589537-10.6294 13.560686-3.583113 2.143898-10.152704 3.763432-13.122829 3.146862-4.163503-.627999-8.726025-5.29165-12.072369-9.909655-4.233369-5.844005-7.334608-14.008012-11.625012-19.024014-3.980994-4.654004-9.64022-7.516009-15.017127-3.738004-2.657798 1.87-5.252858 5.234005-7.264742 8.834006-3.213882 5.746006-1.35537 13.216378 7.060039 14.846379 6.62253.570456 9.975141-.319535 18.760046-4.235284 11.324843-5.30799 19.394028-12.24775 40.954815-28.614778-12.043687 12.50711-.628547.32154-12.437647 12.754045-5.997078 6.313662-18.004788 13.530839-30.602436 20.875652-5.970206 3.424204-11.217218 5.604004-18.891181 7.474206-4.592685 1.12-11.355525 2.157801-12.836991-2.716002-1.542777-5.080003 2.138786-12.912211 2.905897-14.610012 5.78898-12.80201 14.433952-26.094021 29.549462-24.120022 14.415415 1.884004 15.095402 24.373896 25.85492 30.283902 5.298343 2.909802 9.250264.510269 19.414555-4.807967z" fill="#0cc" stroke="none"/><path d="m90.120937 55.223446c-10.76932 13.49115-.33643.589537-10.6294 13.560686-3.58311 2.143898-10.1527 3.763432-13.12282 3.146862-4.16351-.627999-8.72603-5.29165-12.07237-9.909655-4.23337-5.844005-7.33461-14.008012-11.62502-19.024014-3.98099-4.654004-9.64022-7.516009-15.01712-3.738004-2.6578 1.87-5.25286 5.234005-7.26474 8.834006-3.21389 5.746006-1.35537 13.216378 7.06003 14.846379 6.62253.570456 9.97515-.319535 18.76005-4.235284 11.32484-5.30799 19.39403-12.24775 40.95481-28.614778-12.04368 12.50711-.62854.32154-12.43764 12.754045-5.99708 6.313662-18.00479 13.530839-30.60244 20.875652-5.9702 3.424204-11.21722 5.604004-18.89118 7.474206-4.59268 1.12-11.35552 2.157801-12.83699-2.716002-1.54278-5.080003 2.13879-12.912211 2.9059-14.610012 5.78898-12.80201 14.43395-26.094021 29.54946-24.120022 14.41541 1.884004 15.0954 24.373896 25.85492 30.283902 5.29834 2.909802 9.25026.510269 19.41455-4.807967z" style="fill:none;stroke:#0cc;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-opacity:.15686275"/><path d="m90.120937 55.223446c-10.76932 13.49115-.33643.58954-10.6294 13.56069-3.58311 2.1439-10.1527 3.76343-13.12282 3.14686-4.16351-.628-8.72603-5.29165-12.07237-9.90965-4.23337-5.84401-7.33461-14.00801-11.62502-19.02402-3.98099-4.654-9.64022-7.516-15.01712-3.738-2.6578 1.87-5.25286 5.234-7.26474 8.83401-3.21389 5.746-1.35537 13.21637 7.06003 14.84637 6.62253.57046 9.97515-.31953 18.76005-4.23528 11.32484-5.30799 19.39403-12.24775 40.95481-28.61478-12.04368 12.50711-.62854.32154-12.43764 12.75405-5.99708 6.31366-18.00479 13.53084-30.60244 20.87565-5.9702 3.4242-11.21722 5.604-18.89118 7.47421-4.59268 1.12-11.35552 2.1578-12.83699-2.71601-1.54278-5.08 2.13879-12.91221 2.9059-14.61001 5.78898-12.80201 14.43395-26.09402 29.54946-24.12002 14.41541 1.884 15.0954 24.3739 25.85492 30.2839 5.29834 2.9098 9.25026.51027 19.41455-4.80797z" style="fill:none;stroke:#0cc;stroke-width:6;stroke-linecap:round;stroke-linejoin:round;stroke-opacity:.15686275"/><path d="m90.120937 55.223446c-10.76932 13.49115-.33643.58954-10.6294 13.56069-3.58311 2.14389-10.1527 3.76343-13.12282 3.14686-4.16351-.628-8.72603-5.29165-12.07237-9.90966-4.23337-5.844-7.33461-14.008009-11.62502-19.024011-3.98099-4.654003-9.64022-7.516008-15.01712-3.738003-2.6578 1.869999-5.25286 5.234004-7.26474 8.834005-3.21389 5.746006-1.35537 13.216379 7.06003 14.846379 6.62253.57046 9.97515-.31953 18.76005-4.23528 11.32484-5.307994 19.39403-12.247754 40.95481-28.614781-12.04368 12.507109-.62854.32154-12.43764 12.754044-5.99708 6.313662-18.00479 13.530837-30.60244 20.875657-5.9702 3.4242-11.21722 5.604-18.89118 7.4742-4.59268 1.12-11.35552 2.1578-12.83699-2.716-1.54278-5.08 2.13879-12.91221 2.9059-14.610013 5.78898-12.80201 14.43395-26.09402 29.54946-24.120021 14.41541 1.884004 15.0954 24.373895 25.85492 30.283904 5.29834 2.9098 9.25026.51027 19.41455-4.80797z" style="fill:none;stroke:#0cc;stroke-width:4;stroke-linecap:round;stroke-linejoin:round;stroke-opacity:.15686275"/><path d="m90.120937 55.223444c-10.76932 13.49115-.33643.58954-10.6294 13.56069-3.58311 2.14389-10.152699 3.76343-13.12282 3.14686-4.163506-.628-8.726025-5.29165-12.072366-9.90966-4.23337-5.844-7.33461-14.00801-11.62502-19.02401-3.98099-4.65401-9.64022-7.51601-15.01712-3.73801-2.6578 1.87-5.25286 5.23401-7.26474 8.83401-3.21389 5.746-1.35537 13.21638 7.06003 14.84638 6.62253.57046 9.97515-.31953 18.76005-4.23528 11.324841-5.308 19.394027-12.24776 40.954806-28.61478-12.04368 12.50711-.62854.32154-12.43764 12.75404-5.99708 6.31366-18.004785 13.53084-30.602436 20.87566-5.9702 3.4242-11.21722 5.604-18.89118 7.4742-4.59268 1.12-11.35552 2.1578-12.83699-2.716-1.54278-5.08 2.13879-12.91221 2.9059-14.61002 5.78898-12.80201 14.43395-26.09402 29.54946-24.12002 14.41541 1.88401 15.0954 24.3739 25.854916 30.28391 5.29834 2.9098 9.25026.51027 19.41455-4.80797z" style="fill:none;stroke:#0cc;stroke-width:8;stroke-linecap:round;stroke-linejoin:round;stroke-opacity:.15686275"/></g></svg>

<<<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants