Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Files larger than 100MB not uploading / better handling of chunk limits #6473

Closed
5 of 8 tasks
N-Hertstein opened this issue Feb 21, 2024 · 4 comments
Closed
5 of 8 tasks

Comments

@N-Hertstein
Copy link

N-Hertstein commented Feb 21, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

I am using Nextcloud behind nginx proxy manager and cloudflare. I have given a few family members access to my Nextcloud server, however they cannot upload files larger than 100MB due to the cloudflare upload limit. Now I understand that I can change the max chunksize in the client config file, however this is not a real solution. I can't teach my gandpa how to installl teamviewer so I can fix his shit every time he has a new laptop. And businesses cannot be expected to change this for every pc in a large scale deployment. Since Cloudflare is so widely used either the default chunksize needs to be <100MB or I need to be able to adjust this from the server.

Steps to reproduce

  1. Have a nextcloud server
  2. Set it up with cloudflare
  3. Install nexcloud client on family's computer
  4. Wait until they inevitably have a file >100MB
  5. Get constant errors
  6. Get constant texts about errors

Expected behavior

  1. Have a nextcloud server
  2. Set it up with cloudflare
  3. Install nexcloud client on family's computer
  4. Wait until they inevitabaly
  5. Chunksize is <100MB resulting in a working system OR: Get errors and adjust chunksize in server

Installation method

None

Nextcloud Server version

28.0.2

Operating system

Docker Linux (Debian/Truenas Scale)

PHP engine version

8.2.16

Web server

Uncertain of what to put here

Database engine version

PostgreSQL 13.1 (Debian 13.1-1.pgdg100+1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 8.3.0-6) 8.3.0, 64-bit

Is this bug present after an update or on a fresh install?

Yes

Are you using the Nextcloud Server Encryption module?

Nope

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

Default apps + cookbook

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@solracsf
Copy link
Member

You can adjust max_chunk_size server side.
See docs or reach help at https://help.nextcloud.com

@solracsf solracsf closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
@joshtrichards
Copy link
Member

joshtrichards commented Feb 21, 2024

You can adjust max_chunk_size server side.

AFAIK this only changes it for the Web client.

And businesses cannot be expected to change this for every pc in a large scale deployment.

Businesses often have other preferred ways of mass deploying internal software such as the Desktop client, including config customizations. In addition, as noted, it's not an issue for the Web client.

It's possible the Desktop client is being more aggressive than our Web client at determining maximum chunk size.

I think the uploader in Web most of the time effectively uses the default of 10 MiB (unless the file is particularly large or the admin has changed it from the default).

I haven't fully been through the Desktop client's approach in this area, but I going from memory I got the sense Desktop may start out trying to use as few chunks as possible (and therefore much larger ones), whereas Web kind of does the opposite.

I may be wrong though because I only glanced at the code a bit back and so take with a grain of salt.

https://github.com/search?q=repo%3Anextcloud%2Fdesktop%20maxchunksize&type=code

The Desktop client also has a dynamic mode that adapts based on target duration parameters, which further complicates things (and I'm not aware of the Web client having any such thing).

@joshtrichards joshtrichards transferred this issue from nextcloud/server Feb 21, 2024
@joshtrichards joshtrichards reopened this Feb 21, 2024
@joshtrichards joshtrichards changed the title [Bug]: Files larger than 100MB not uploading [Bug]: Files larger than 100MB not uploading / better handling of chunk limits Feb 21, 2024
@joshtrichards
Copy link
Member

P.S. I apologize for leaning a bit more on speculation than I usually prefer in my response a short bit ago.

My aim was to add a bit to the discussion, but upon reflection I probably should have just left it as a draft for now. :-)

This topic just happens to connect with one I've had on my "to investigate" list for a bit: the behavior of chunking, particularly in a default configuration, in the Desktop versus Web clients.

(Lacking time today to get deeply into this, I'm drawing heavily on memory and an incomplete prior review of the Desktop chunking code).

This is mostly a disclaimer to take my speculation about differences in behavior with a grain of salt for now. :-)

@joshtrichards
Copy link
Member

Duplicate of #4278

@joshtrichards joshtrichards marked this as a duplicate of #4278 Aug 15, 2024
@joshtrichards joshtrichards closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants