Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications don't trigger for actions initiated by yourself #15

Open
theCalcaholic opened this issue Feb 10, 2021 · 8 comments
Open
Labels
enhancement New feature or request

Comments

@theCalcaholic
Copy link

I have set up a simple test case:

image

The NC Talk flow is just there to verify that I didn't misconfigure the conditions. When I edit/rename a file called test.md to test1.md (or vice versa), I get a message in Talk but no notification.

NC version: 20.0.4
Flow Notifications version: 1.0.3

@MarVinSto
Copy link

Can confirm with:
NC version: 20.0.5
Flow Notifications version: 1.0.3

@snarchio
Copy link

Can confirm with:
NC version: 20.0.8
Flow Notifications version: 1.0.3

@blizzz
Copy link
Member

blizzz commented Feb 26, 2021

Cannot confirm on 20.0.8 / 1.0.3.

Please note that the notification is not triggered, when you do the action yourself.

@snarchio
Copy link

Cannot confirm on 20.0.8 / 1.0.3.

Please note that the notification is not triggered, when you do the action yourself.

Sorry, my mistake in testing after the update

@theCalcaholic
Copy link
Author

@blizzz Oh, so this is intended behavior? IMO, this could be configurable. I don't always access files manually, but also in various automated tasks via scripts, which might be a use case for this flow.

Anyways, I'll test the app with another user and report back in a minute.

@blizzz
Copy link
Member

blizzz commented Mar 1, 2021

@blizzz Oh, so this is intended behavior? IMO, this could be configurable. I don't always access files manually, but also in various automated tasks via scripts, which might be a use case for this flow.

Anyways, I'll test the app with another user and report back in a minute.

Yes, it is intended and also worked like this. Does not mean it has to be like this forever (but then opt-in).

@MarVinSto
Copy link

MarVinSto commented Apr 28, 2021

Cannot confirm on 20.0.8 / 1.0.3.

Please note that the notification is not triggered, when you do the action yourself.

Sorry, this was my fault!
Is it possible that notifications are also not created if the files are in group folders?
If yes: Is there a workaround to make that happen?

@blizzz
Copy link
Member

blizzz commented Oct 22, 2021

Is it possible that notifications are also not created if the files are in group folders?

This should not be the case. There is no introspection into files. The check for ownership as pointed out above is the only one we do in this app.

@blizzz blizzz changed the title Notifications don't trigger Notifications don't trigger for actions initiated by yourself Oct 22, 2021
@blizzz blizzz added the enhancement New feature or request label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants