Feat: Search mail bodies #8897
Feat: Search mail bodies #8897
Conversation
hamza221
requested review from
ChristophWurst,
st3iny,
kesselb and
miaulalala
lib/Db/MessageMapper.php
Outdated
| @@ -832,7 +832,7 @@ public function findIdsByQuery(Mailbox $mailbox, SearchQuery $query, ?int $limit | |||
|
|
|||
| // createParameter | |||
| if ($uids !== null) { | |||
| $select->andWhere( | |||
| $select->orWhere( | |||
|
Code looks good! Right now there is a new dedicated input in the advanced search. We also discussed an opt-in feature to search in bodies in the search box on top of envelopes, right? I'm fine with doing another PR. |
|
cant blive this is not option yet, very usefull. Cant wait to test it :) |
|
If I search for a body term only, the search doesn't really have an affect. I also get messages without the search term. Is it the AND vs OR combination of the IMAP and DB results? |
It is. So if I'm correct, the only case where we need an orWhere is when we're searching both body and subject, all other combinations should be andWhere. |
|
Works! |
Signed-off-by: hamza221 <[email protected]>
hamza221
force-pushed
the
feat/search-body
branch
from
fbb72c0 to
eb93d46
Compare
|
@ChristophWurst Hi. Could we have this released in Nextcloud Mail 3.4.5? Thank you! |
Could we consider to have opt-in features in basic search set in the advanced search settings like in Roundcube? EDIT: I submitted the issue: #9044 in order to track it. |
Fixes #8050