Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of Kotlin as programming language #1183

Closed
Unpublished opened this issue Apr 9, 2023 · 3 comments · Fixed by #1192
Closed

Usage of Kotlin as programming language #1183

Unpublished opened this issue Apr 9, 2023 · 3 comments · Fixed by #1192

Comments

@Unpublished
Copy link
Collaborator

What are your thoughts on migrating to Kotlin incrementally as done for nextclient android client app, @David-Development?

Would like to take a stab on it

@David-Development
Copy link
Member

@Unpublished Sounds great to me! Personally I like a lot of the concepts in Kotlin. Are you suggestion to migrate "just" the programming language or also migrate to newer Android concepts such as Compose? Our dependencies (such as Android Single Sign On Library) should support Kotlin as well (If there are issues I'm happy to have a look at it - there used to be some issues related to return types in kotlin but I can't say for sure that they still exist in the latest version - nextcloud/Android-SingleSignOn#177).

As I'm quite busy lately with my day to day job and other side projects my time is quite limited but of course I'll do my best in supporting and reviewing. I'll also try to publish more beta's in the future to bring your great updates to the users faster.

Also in case you have PayPal / Buy Me a Coffee / Flattr let me know!

@Unpublished
Copy link
Collaborator Author

@Unpublished Sounds great to me! Personally I like a lot of the concepts in Kotlin. Are you suggestion to migrate "just" the programming language or also migrate to newer Android concepts such as Compose? Our dependencies (such as Android Single Sign On Library) should support Kotlin as well (If there are issues I'm happy to have a look at it - there used to be some issues related to return types in kotlin but I can't say for sure that they still exist in the latest version - nextcloud/Android-SingleSignOn#177).

Happy to hear! Didn't have Compose on my mind while opening this issue (as I haven't used it yet) but sure using Kotlin would allow us to use Compose in future. Migration to Compose can be done incrementally as well AFAIR.
Good to know in case there are issues I stumble upon.

As I'm quite busy lately with my day to day job and other side projects my time is quite limited but of course I'll do my best in supporting and reviewing. I'll also try to publish more beta's in the future to bring your great updates to the users faster.

Also in case you have PayPal / Buy Me a Coffee / Flattr let me know!

Thank you for all your work on news-android, I'm happy with just contributing my little modifications to you/Nextcloud users :)

@David-Development
Copy link
Member

Sounds great to me. Incrementally migrating sounds like the way to go - especially to migrate Java to Kotlin first and then consider migrating to compose incrementally.

Thank you for all your work on news-android, I'm happy with just contributing my little modifications to you/Nextcloud users :)

Thank you! It's fantastic to have an active community and people that help improve the app! Thank you so much for your contributions! 🙇‍♂️ 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants