-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the common webpack configuration #2625
Conversation
afdfb05
to
8b084ec
Compare
This comment was marked as resolved.
This comment was marked as resolved.
3d29e12
to
6674b69
Compare
6674b69
to
dc558b0
Compare
@skjnldsv There might be an issue with |
Since this PR might be blocked for a while by this, I split the |
dc558b0
to
c00ef7e
Compare
c00ef7e
to
d9ee3ba
Compare
I looked into this Issue for myself a bit, because I wanted to have vue 3 and if I see it correctly then vue-styleguidist uses a old Version of webpack-dev-server (3.11.3 instead of 4.7.2). And that Version can't be updated until react-styleguidist updates their version from 3.x to 4.x. They are working on that update with a lot of other changes for webpack 5 (styleguidist/react-styleguidist#1996). |
Signed-off-by: Raimund Schlüßler <[email protected]>
d9ee3ba
to
c7860c0
Compare
This is done with version |
I think at this point we should move to vite and use the docgen-vite |
I spend a quite some time porting it to webpack 5, but there is a bunch of dependencies pulling in old versions of |
Fine with me. I close this issue then. In case vue-styleguidist moves to webpack5 before we move to vite, we can still revisit this PR. |
This migrates
nextcloud/vue
to the commonnextcloud/webpack-vue-configuration
. This simplifies the configuration drastically and also includes the legendary migration fromnode-sass
tosass
😉As a side note, the style guide only works properly when compiled in development mode, but it was like this before already.
Because we now use
sass
we see someDeprecation Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.
warnings, which will be fixed in a follow-up PR.