ncp-config: dont save passwords

Signed-off-by: Tobias Knöppler <[email protected]> Signed-off-by: nachoparker <[email protected]>
nextcloud · Jan 22, 2020 · 4a99207 · theCalcaholic · Jan 22, 2020 · nachoparker
1 parent 3af0c46
commit 4a99207
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/bin/ncp/CONFIG/nc-passwd.sh b/bin/ncp/CONFIG/nc-passwd.sh
@@ -8,8 +8,6 @@
 # More at: https://ownyourbits.com
 #
 
-
-
 configure()
 {
   # update password

diff --git a/etc/library.sh b/etc/library.sh
@@ -150,6 +150,7 @@ function run_app_unsafe()
 
   echo "" >> $log
 
+  clear_password_fields "$cfg_file"
   return "$ret"
 }
 
@@ -278,6 +279,20 @@ function check_distro()
   return 1
 }
 
+function clear_password_fields()
+{
+  local cfg_file="$1"
+  local cfg="$(cat "$cfg_file")"
+  local len="$(jq '.params | length' <<<"$cfg")"
+  for (( i = 0 ; i < len ; i++ )); do
+    local type="$(jq -r ".params[$i].type"  <<<"$cfg")"
+    local val="$( jq -r ".params[$i].value" <<<"$cfg")"
+    [[ "$type" == "password" ]] && val=""
+    cfg="$(jq -r ".params[$i].value=\"$val\"" <<<"$cfg")"
+  done
+  echo "$cfg" > "$cfg_file"
+}
+
 function apt_install()
 {
   apt-get update
-Original file line number
+Diff line change
@@ Expand Up / @@ -8,8 +8,6 @@ @@
     # More at: https://ownyourbits.com
     #
     configure()
     {
       # update password
@@ Expand Down @@