Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external image processing libraries #13551

Closed
rullzer opened this issue Jan 13, 2019 · 10 comments
Closed

Allow external image processing libraries #13551

rullzer opened this issue Jan 13, 2019 · 10 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement performance 🚀

Comments

@rullzer
Copy link
Member

rullzer commented Jan 13, 2019

Our default image processing backend if gd. Even if the previews are provided by a 3rdparty provider the scaling is still done by a gd backend. Which is not the fastest.

I was thinking of allowing users to configure an optional different backend to handle the images. For example I have been using https://github.com/h2non/imaginary in other projects. it is fast, scaleable and works as advertised.

Of course the default GD backend should stay as the default. But for people that want more performance out of their nextcloud I think this could be a nice boost (jus the same as we allow people to configure redis for locking).

@MorrisJobke @ChristophWurst @skjnldsv @juliushaertl opionions?

@rullzer rullzer added enhancement 1. to develop Accepted and waiting to be taken care of labels Jan 13, 2019
@skjnldsv
Copy link
Member

This would solve our imagick issue #13099

@rullzer
Copy link
Member Author

rullzer commented Jan 13, 2019

At least partly yes

@MorrisJobke
Copy link
Member

Sounds sane and allows to pinpoint performance bottlenecks 👍 Separation of concerns often helps to also isolate possible security issues by not allowing this rendering farm to have any external communication.

@enoch85
Copy link
Member

enoch85 commented Jan 17, 2019

Not being a PHP dev, why not use the one with better performance as the default one? We all want NC to fly! :)

@Alexandero89
Copy link

Hello,
was there any progress at this topic? ;)

@nachoparker
Copy link
Member

Oh! I found this discussion a bit too late. I was playing with extending OC_Image with a OC_Image_JPEG class that uses Imagick and I was able to achieve better performance.

See https://ownyourbits.com/2019/06/29/understanding-and-improving-nextcloud-previews/

@solracsf
Copy link
Member

solracsf commented Dec 22, 2019

This would be Indeed a great value for big NC instances with a lot of pictures. A scalable (external) processor is a must-have!

@maanloper
Copy link

@rullzer any updates on this? Seems to me these days https://github.com/h2non/imaginary supports all relevant formats.

@pachulo
Copy link
Contributor

pachulo commented Mar 19, 2022

Maybe now that this has been merged this issue can be closed?

@solracsf
Copy link
Member

Closing as per #24166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement performance 🚀
Projects
None yet
Development

No branches or pull requests

10 participants