-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow external image processing libraries #13551
Comments
This would solve our imagick issue #13099 |
At least partly yes |
Sounds sane and allows to pinpoint performance bottlenecks 👍 Separation of concerns often helps to also isolate possible security issues by not allowing this rendering farm to have any external communication. |
Not being a PHP dev, why not use the one with better performance as the default one? We all want NC to fly! :) |
Hello, |
Oh! I found this discussion a bit too late. I was playing with extending See https://ownyourbits.com/2019/06/29/understanding-and-improving-nextcloud-previews/ |
This would be Indeed a great value for big NC instances with a lot of pictures. A scalable (external) processor is a must-have! |
@rullzer any updates on this? Seems to me these days https://github.com/h2non/imaginary supports all relevant formats. |
Maybe now that this has been merged this issue can be closed? |
Closing as per #24166 |
Our default image processing backend if gd. Even if the previews are provided by a 3rdparty provider the scaling is still done by a gd backend. Which is not the fastest.
I was thinking of allowing users to configure an optional different backend to handle the images. For example I have been using https://github.com/h2non/imaginary in other projects. it is fast, scaleable and works as advertised.
Of course the default GD backend should stay as the default. But for people that want more performance out of their nextcloud I think this could be a nice boost (jus the same as we allow people to configure redis for locking).
@MorrisJobke @ChristophWurst @skjnldsv @juliushaertl opionions?
The text was updated successfully, but these errors were encountered: