Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce password on share-links for everybody except a defined group #30161

Closed
3 tasks
AndyScherzinger opened this issue Dec 9, 2021 · 3 comments
Closed
3 tasks

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Dec 9, 2021

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

The rule for creating external links to files only with a password is enabled for everyone, but only a certain group of users can create external links to files without a password. This come from Security.

Describe the solution you'd like
--> Basically the ability to enforce passwords for external link shares for every user except when you are in a special group

Describe alternatives you've considered
none

Additional context

basically we need to get the users group memberships in

public function shareApiLinkEnforcePassword() {
return $this->config->getAppValue('core', 'shareapi_enforce_links_password', 'no') === 'yes';
}
and then check it additionally against the configured groups.

  • A few more locations in the code where this config setting is read separately from this one (like capabilities and some legacy things that might still be in use).

  • We also need to clarify whether we need to also adjust the UI to add a new field "The following groups are exempted from password enforcement"

  • Needs to be available within Q1 for customers (so backport to 23 will be needed, likely not for v22)

@AndyScherzinger AndyScherzinger added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 9, 2021
@skjnldsv skjnldsv added this to the Nextcloud 23.0.1 milestone Dec 13, 2021
@CarlSchwan
Copy link
Member

Implemented in #31194, I still need to adapt the tests and ideally add a few new ones to cover this case

@blizzz blizzz modified the milestones: Nextcloud 23.0.2, Nextcloud 24 Feb 15, 2022
@AndyScherzinger
Copy link
Member Author

It'll need backporting, likely v22

@CarlSchwan does your latest comment imply that the feature is implemented besides the tests part? 👀

@AndyScherzinger AndyScherzinger added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 15, 2022
@CarlSchwan
Copy link
Member

yes, it is. I'll try to find some time this week to fix the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants