Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed caches are always mem caches #31787

Open
ChristophWurst opened this issue Apr 1, 2022 · 0 comments
Open

Distributed caches are always mem caches #31787

ChristophWurst opened this issue Apr 1, 2022 · 0 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: caching Related to our caching system: scssCacher, jsCombiner... integration

Comments

@ChristophWurst
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

\OCP\ICacheFactory::createDistributed returns a \OCP\ICache. In practice the objects are always \OCP\IMemcache, similar to createLocking results.

From a static analysis point of view you can't rely on that assumption.

Describe the solution you'd like

Finish #30072 so the interface returns a more specific type. This is not a backwards compatible change as any code that expected an ICache will still work.

Describe alternatives you've considered

N/a

Additional context

N/a

@ChristophWurst ChristophWurst added enhancement 1. to develop Accepted and waiting to be taken care of integration feature: caching Related to our caching system: scssCacher, jsCombiner... labels Apr 1, 2022
@ChristophWurst ChristophWurst moved this to 📄 To do (5-20 entries) in 💌 📅 👥 Groupware team Apr 1, 2022
@ChristophWurst ChristophWurst moved this from 📄 To do (5-20 entries) to 🧭 Planning evaluation (dont pick) in 💌 📅 👥 Groupware team Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: caching Related to our caching system: scssCacher, jsCombiner... integration
Projects
Status: 🧭 Planning evaluation
Development

No branches or pull requests

1 participant