Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: icons in the header are too crowded and a scollbar is shown #46997

Closed
susnux opened this issue Aug 2, 2024 · 3 comments
Closed

[Bug]: icons in the header are too crowded and a scollbar is shown #46997

susnux opened this issue Aug 2, 2024 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug feature: files

Comments

@susnux
Copy link
Contributor

susnux commented Aug 2, 2024

The right header menu has a scrollbar on small mobile, this should instead go into an overflow menu.

image

@susnux susnux added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback labels Aug 2, 2024
@szaimen szaimen moved this to 👓 Design review in 🖍 Design team Aug 2, 2024
@susnux
Copy link
Contributor Author

susnux commented Aug 5, 2024

Obvious solution: Add an overflow menu like for apps. But this does not work as e.g. the contacts menu has a popover and is not just a button. And I am pretty sure I saw a comment by @jancborchardt that we do not want a second overflow menu.

My idea (but this needs adjustments):
Similar to the one above, but not overflow into an extra menu but simply into the account menu (the one that opens when you click on your avatar).
Also add some priority to those actions to define when something will be moved into the overflow, like I think notifications is the most important and you always stay visible etc.
This way we do not add a new overflow menu.

@jancborchardt
Copy link
Member

@susnux yeah, your idea of overflowing it into the account menu is nice. Another option, a more low-hanging fix, could be to reduce the horizontal spacing between the icons on mobile.

E.g. the notifications, contacts and account menu already seem to be "compressed", while only Assistant and search take up a lot of width. This could be compressed on mobile? (It is similar to how iOS does it with app titles on the home screen, where the font tracking is reduced first before ellipsis.)

@szaimen
Copy link
Contributor

szaimen commented Dec 30, 2024

This seems to be fixed in master now :)

@szaimen szaimen closed this as completed Dec 30, 2024
@github-project-automation github-project-automation bot moved this from 👓 Design review to 🎉 Done in 🖍 Design team Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback bug feature: files
Projects
Status: 🎉 Done
Development

No branches or pull requests

4 participants