Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] use a lazy user for the file owner when listing a directory #32118

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Apr 25, 2022

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #32082

@CarlSchwan
Copy link
Member

/rebase

@PVince81
Copy link
Member

seems this requires the display name cache, which we haven't merged yet: #32065

@PVince81
Copy link
Member

okay merged. I'm not sure if we can ask the bot to redo a backport. I'll try...

@PVince81 PVince81 closed this Apr 25, 2022
@CarlSchwan CarlSchwan reopened this Apr 25, 2022
@CarlSchwan
Copy link
Member

I'll take care of the manual rebasing

Only getUID and getDisplayName are called on the file owner objects anyway
and we can get this information often without DB request

Signed-off-by: Robin Appelman <[email protected]>
@CarlSchwan CarlSchwan force-pushed the backport/32082/stable24 branch from 441db73 to 79672ed Compare April 25, 2022 12:59
@PVince81
Copy link
Member

I'll take care of the manual rebasing

do you mean re-cherry-picking the original ? because it said the backport was incomplete so rebasing would not solve that

@CarlSchwan
Copy link
Member

I'll take care of the manual rebasing

do you mean re-cherry-picking the original ? because it said the backport was incomplete so rebasing would not solve that

No, the missing parts was the autoloader changes, I just regenerated it :)

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added the 4. to release Ready to be released and/or waiting for tests to finish label Apr 25, 2022
@PVince81 PVince81 merged commit af42584 into stable24 Apr 25, 2022
@PVince81 PVince81 deleted the backport/32082/stable24 branch April 25, 2022 14:27
@blizzz blizzz mentioned this pull request Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish performance 🚀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants