[stable23] Allow to tweak default scopes for accounts #32449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
Close #6582 Signed-off-by: Thomas Citharel <[email protected]>
backportbot-nextcloud
bot
added
enhancement
feature: users and groups
php
backportbot-nextcloud
bot
requested review from
blizzz,
ChristophWurst,
jancborchardt,
juliusknorr,
nickvergessen,
Pytal and
tcitworld
tcitworld
requested changes
May 17, 2022
| /** @var string accounts table name */ | ||
| private $table = 'accounts'; | ||
| /** accounts table name */ | ||
| private string $table = 'accounts'; |
|
|
||
| /** @var LoggerInterface|MockObject */ | ||
| private $logger; | ||
|
|
||
| /** @var AccountManager */ | ||
| private $accountManager; | ||
| private AccountManager $accountManager; |
|
I suppose if we merge this we would need a new minor release? |
This was referenced Jun 7, 2022
Closed
Closed
Closed
Closed
Merged
|
Does it really need backports? I don't think so. |
|
|
At least moving to 23.0.7 for now for it is not even in review state. |
|
So seems like we will not merge this? then lets close it. |
|
If we can make it work for 23 with little effort (the php 7.3 compatibility) I'd say do it, else let's skip 23 but def. do 24 |
Merged
|
moving to 23.0.8… |
Merged
|
@PVince81 what do we do here? |
|
let's not backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #31623