Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(absence): Don't break when you are the absence or it's recursion #14304

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix(absence): Don't break when you are the absence or it's recursion #14304

merged 1 commit into from
Feb 7, 2025

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 6, 2025 •
edited by Antreesy
Loading

☑️ Resolves

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@nickvergessen nickvergessen added this to the 🪺 Next Major (32) milestone Feb 6, 2025
@nickvergessen nickvergessen self-assigned this Feb 6, 2025
@nickvergessen nickvergessen added the feature: frontend 🖌️ "Web UI" client label Feb 6, 2025
Antreesy
Antreesy approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, good enough

@nickvergessen
Copy link
Member Author

/backport to stable31

@nickvergessen nickvergessen merged commit 275c5ec into main Feb 7, 2025
53 checks passed
@nickvergessen nickvergessen deleted the bugfix/14288/no-absence-loop-or-break branch February 7, 2025 00:06
@backportbot backportbot bot mentioned this pull request Feb 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🪺 Next Major (32)
Development

Successfully merging this pull request may close these issues.

[OOO] Disable opening a new conversation when you're the replacement
2 participants
@nickvergessen @Antreesy