[stable24] Fix modal heights #2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
julien-nc,
juliusknorr,
max-nextcloud,
mejo- and
vinicius73
vinicius73
approved these changes
Apr 19, 2022
|
/compile amend |
nextcloud-command
force-pushed
the
backport/2312/stable24
branch
from
08c9a61 to
48584b2
Compare
juliusknorr
approved these changes
Apr 19, 2022
|
/compile amend |
nextcloud-command
force-pushed
the
backport/2312/stable24
branch
from
48584b2 to
3d46058
Compare
Signed-off-by: Jonas <[email protected]> Fixes: #2203
On mobile, `#modal-container` already has `top: 50px`, so no need to add another `top: 50px` in `#editor-container` in that case. Also, remove `top` property from `#editor-container` in EditorWrapper and RichWorkspace altogether. The correct place to set `top` to fit with the header bar from a modal is ViewerComponent. Fixes: #2203 Fixes: #2295 Signed-off-by: Jonas <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
mejo-
force-pushed
the
backport/2312/stable24
branch
from
3d46058 to
7d1f43b
Compare
mejo-
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2312