Trigger event on content change in syncservice #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 31, 2022 16:15
Signed-off-by: Vinicius Reis <[email protected]>
Signed-off-by: Vinicius Reis <[email protected]>
Signed-off-by: Vinicius Reis <[email protected]>
vinicius73
added
enhancement
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
…on-content-change-in-syncservice
delete-merged-branch
bot
deleted the
2462-trigger-event-on-content-change-in-syncservice
branch
|
/backport to stable24 |
|
Not sure if we really want to backport this - but since it prevents memory leaks and cleans things up seems like a good idea. |
|
The backport to stable24 failed. Please do this backport manually. |
|
Manual backported to stable24 in #2679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fires 4 events from
SyncServicesync-service:idlesync-service:savesync-service:errorsync-service:syncPrevention of Memory Leak
All
SyncServiceevent handlers are storage in arrays, and never removed from these arrays.Although the
SyncServicewhore removed from Vue component context, we had a circular reference here.This is a very common scenario for Memory Leak in JavaScript.
Now using
mittlibrary is possible to use.offto remove an event handler.To do it, I've change part of event contracts (error event) and I've split the event handlers in component methods.
There are more potential problems to solve, but we can do it later.