[stable24] Trigger event on content change in syncservice #2679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #2465
Summary
Fires 4 events from
SyncService
sync-service:idle
sync-service:save
sync-service:error
sync-service:sync
Prevention of Memory Leak
All
SyncService
event handlers are storage in arrays, and never removed from these arrays.Although the
SyncService
whore removed from Vue component context, we had a circular reference here.This is a very common scenario for Memory Leak in JavaScript.
Now using
mitt
library is possible to use.off
to remove an event handler.To do it, I've change part of event contracts (error event) and I've split the event handlers in component methods.
There are more potential problems to solve, but we can do it later.